-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for building x86 in Visual Studio for non-windows OS #7884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retest this please. python failed on keyword "warnings", not failure. |
Retest this please. Python port:
|
Failures are not related to this PR. @douzzer please review when you can. Thank you |
Retest this please |
2 similar comments
Retest this please |
Retest this please |
douzzer
approved these changes
Aug 23, 2024
douzzer
approved these changes
Aug 23, 2024
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Oct 22, 2024
…owup to PR wolfSSL#7884. Expands the `WOLFSSL_NOT_WINDOWS_API` improvement for intrinsics and word sizes. Fixes ZD 18465
4 tasks
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Oct 24, 2024
…owup to PR wolfSSL#7884. Expands the `WOLFSSL_NOT_WINDOWS_API` improvement for intrinsics and word sizes. Fixes ZD 18465
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Oct 29, 2024
…om C compiler). Followup to PR wolfSSL#7884. Fixes ZD 18465 * Consolidate the USE_WINDOWS_API to a single place. * Expand the `WOLFSSL_NOT_WINDOWS_API` improvement for intrinsics and word sizes. * Fix for macro variadic `...` when no variables are used (some compilers like Watcom C have issue with this). * Fix for Watcom C compiler "long long" -> "__int64". * Fix a couple of minor cast warnings reported from VS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for building x86 in Visual Studio for non-windows OS. Adds new build option
WOLFSSL_NOT_WINDOWS_API
for platforms where the target OS is not Windows, but compilation is done on Windows/Visual Studio.Fixes ZD 18465
Testing
Checklist