-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WOLFSSL_SP_INT_NEGATIVE declaration for all Espressif chipsets #6374
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1a0a83c
WOLFSSL_SP_INT_NEGATIVE declaration for all Espressif chipsets
gojimmypi 19961ae
correct naming for WOLFSSL_SHA384 on ESP32-C3
gojimmypi 2ec486e
code review changes; common handling of negative MATH_INT_T
gojimmypi 7aa07f0
code review update: address mixed declaration with code.
gojimmypi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend this just be
int neg
and keep the existing setting of it inCONFIG_IDF_TARGET_ESP32S3
. The !CONFIG_IDF_TARGET_ESP32S3 case overrides this with a different value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point on the code inconsistency. I left the declaration & assignment at the top and instead moved the
Z->sign
logic completely out of the IF/CONFIG sections.The negative flag setting is now assigned regardless of
IDF_TARGET_[n]
value at the end of the function as updated in 2ec486e.