Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER: Add crypto API for ChaCha20-Poly1305 #8

Closed
aburks opened this issue Feb 20, 2015 · 4 comments
Closed

ER: Add crypto API for ChaCha20-Poly1305 #8

aburks opened this issue Feb 20, 2015 · 4 comments
Assignees
@JacobBarthelmeh

Comments

@aburks
Copy link
Contributor

aburks commented Feb 20, 2015

Add an API for the ChaCha20-Poly1305 AEAD as defined by https://tools.ietf.org/html/draft-irtf-cfrg-chacha20-poly1305.
@toddouska
Copy link
Contributor

Thanks for the request. We'll work on it this week.

@aburks
Copy link
Contributor Author

aburks commented Feb 24, 2015

I'll actually have a pull request for you tomorrow if you want to wait and have a look at that.

@aburks aburks mentioned this issue Feb 24, 2015
Merged
@aburks
Copy link
Contributor Author

aburks commented Feb 24, 2015

Added pull request #10 to fix this issue.

@toddouska
Copy link
Contributor

Thanks for the pull request, merged.

@SparkiDev SparkiDev mentioned this issue Jun 6, 2017
Merged
@SparkiDev SparkiDev mentioned this issue Jun 14, 2017
Merged
@cve-reporting cve-reporting mentioned this issue Nov 4, 2019
Closed
@vaintroub vaintroub mentioned this issue Jul 25, 2021
Closed
rizlik added a commit to dgarske/wolfssl that referenced this issue Jan 19, 2022
@rizlik
dtls-srtp: check that length of strings matched before memcomparing
9b69f69 
otherwise if profile_str_len is > strlen(gSrtpProfiles[i].name) we end up
comparing memory past gSrtpProfiles[i].name. -fsanitize=address catches this:

```
==100159==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7f40d8d533b2 at pc 0x7f40d8eb014f bp 0x7f40d50fe240 sp 0x7f40d50fd9e8
READ of size 21 at 0x7f40d8d533b2 thread T107
    #0 0x7f40d8eb014e in MemcmpInterceptorCommon(void*, int (*)(void const*, void const*, unsigned long), void const*, void const*, unsigned long) /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:860
    #1 0x7f40d8eb06e6 in __interceptor_memcmp /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:892
    #2 0x7f40d8eb06e6 in __interceptor_memcmp /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:887
    #3 0x7f40d8c2e830 in DtlsSrtpFindProfile src/ssl.c:1310
    #4 0x7f40d8c2e9ed in DtlsSrtpSelProfiles src/ssl.c:1347
    #5 0x7f40d8c2eada in wolfSSL_CTX_set_tlsext_use_srtp src/ssl.c:1359
    #6 0x563bf381b4c5 in server_test examples/server/server.c:2278
    #7 0x7f40d88f0258 in start_thread (/usr/lib/libpthread.so.0+0x9258)
    wolfSSL#8 0x7f40d88195e2 in __GI___clone (/usr/lib/libc.so.6+0xfe5e2)
```
kojo1 pushed a commit to kojo1/wolfssl that referenced this issue Mar 4, 2022
@ejohnstown
Merge pull request wolfSSL#8 from ejohnstown/include-fix
995cf11 
Update the automake include files to add missing items
gojimmypi pushed a commit to gojimmypi/wolfssl that referenced this issue Apr 23, 2022
@rizlik @gojimmypi
dtls-srtp: check that length of strings matched before memcomparing
c9a0bb0 
otherwise if profile_str_len is > strlen(gSrtpProfiles[i].name) we end up
comparing memory past gSrtpProfiles[i].name. -fsanitize=address catches this:

```
==100159==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7f40d8d533b2 at pc 0x7f40d8eb014f bp 0x7f40d50fe240 sp 0x7f40d50fd9e8
READ of size 21 at 0x7f40d8d533b2 thread T107
    #0 0x7f40d8eb014e in MemcmpInterceptorCommon(void*, int (*)(void const*, void const*, unsigned long), void const*, void const*, unsigned long) /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:860
    #1 0x7f40d8eb06e6 in __interceptor_memcmp /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:892
    #2 0x7f40d8eb06e6 in __interceptor_memcmp /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:887
    #3 0x7f40d8c2e830 in DtlsSrtpFindProfile src/ssl.c:1310
    #4 0x7f40d8c2e9ed in DtlsSrtpSelProfiles src/ssl.c:1347
    #5 0x7f40d8c2eada in wolfSSL_CTX_set_tlsext_use_srtp src/ssl.c:1359
    #6 0x563bf381b4c5 in server_test examples/server/server.c:2278
    wolfSSL#7 0x7f40d88f0258 in start_thread (/usr/lib/libpthread.so.0+0x9258)
    wolfSSL#8 0x7f40d88195e2 in __GI___clone (/usr/lib/libc.so.6+0xfe5e2)
```
lealem47 pushed a commit to lealem47/wolfssl that referenced this issue Mar 29, 2023
@toddouska
Merge pull request wolfSSL#8 from wolfSSL/sym_ctx_cache
bd09e90 
Enhancement to allow re-use of the symmetric context for ciphers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobBarthelmeh JacobBarthelmeh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@toddouska @aburks @JacobBarthelmeh