Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable support for STM32U585 #5

Closed
wants to merge 0 commits into from
Closed

Enable support for STM32U585 #5

wants to merge 0 commits into from

Conversation

anhu
Copy link

@anhu anhu commented Feb 10, 2022

  • add a client and server over UART command using DMA.
  • use kyber level 1 if HAVE_PQC is defined.
  • only call TLSX_UseSupportedCurve() for kyber level 1.
  • make sure only one of HAVE_LIBOQS or HAVE_PQM4 is defined.

dgarske
dgarske requested changes Feb 11, 2022
View reviewed changes
Copy link
Owner

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good here. I am not seeing the changes for adding HAVE_PQM4 in this, but I know they are there. Feel free to put up a public wolfSSL PR for this stuff. Might be easier.

IDE/STM32Cube/wolfssl_example.c
#endif
/* This sets which UART to use for the console. It is something you will have
* to configure in STMCubeIDE and then change here. */
#define HAL_CONSOLE_UART huart3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add #ifndef HAL_CONSOLE_UART around this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed on public PR.

@anhu
Copy link
Author

anhu commented Feb 11, 2022

Closing this PR as it has been re-opened as public PR.

@anhu anhu closed this Feb 11, 2022
@anhu anhu removed their assignment Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarske dgarske dgarske requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anhu @dgarske