-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18nIgnore] docs: update starlight-links-validator
to version 0.7.1
#1696
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! This is a great change — thank you @HiDeoo!
One bit of feedback: the error message is a little bit cryptic if you’re not familiar with our trailing slash settings:
▶ ru/reference/plugins/
├─ /ru/reference/configuration - trailing slash
└─ /ru/reference/configuration - trailing slash
It just says “trailing slash”. Something like “Missing trailing slash” or “Trailing slash required” would probably helpful to point people in the right direction when they see this error.
Nevertheless happy to approve this and get it merged before we regress on any more links!
* main: (111 commits) Fix various Expressive Code translation issues (withastro#1708) Fix nested aside title rendering issue (withastro#1703) I18n(pt-PT): Add resources pages (withastro#1678) Add SST Ion & Font Awesome to site showcase (withastro#1710) [ci] format Add SudoVanilla to showcase (withastro#1702) i18n(fr): Update `resources-showcase` (withastro#1697) [i18nIgnore] docs: update `starlight-links-validator` to version `0.7.1` (withastro#1696) [ci] format [ci] release (withastro#1688) [ci] format Update Russian translation (withastro#1616) [ci] format Adds `starlight` icon to Starlight (withastro#1698) Update Icons.ts with Farcaster Purple for SocialIcons (withastro#1622) Remove duplicate from showcase example in `contributing.md` (withastro#1692) i18n(zh-cn): Update `showcase.mdx` (withastro#1689) [ci] format i18n(zh-cn): Update configuration.mdx (withastro#1691) i18n(ko-KR): update `showcase.mdx` (withastro#1690) ...
What kind of changes does this PR include?
Description
This pull request updates the documentation link checker to the version
0.7.1
.The large amount of file changed is due to the documentation using the Astro
trailingSlash
option withalways
and this new version ofstarlight-links-validator
now ensuring that when this option is set, all links respect this option.This finally fixes (and reliably prevents) the annoying issue when developing locally with the documentation and following some random links would result in a 404 error due to a missing trailing slash.