Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for xslURL in sitemap package #8840

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

sondr3
Copy link
Contributor

@sondr3 sondr3 commented Jul 17, 2024

Description

Add documentation for the new xslURL in @astrojs/sitemap.

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a9805af
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6706f0fdec51a900085b85f7
😎 Deploy Preview https://deploy-preview-8840--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jul 17, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/integrations-guide/sitemap.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution, @sondr3 ! The formatting and structure all looks great and you've integrated this content nicely into existing docs!

Just made a tiny edit to make the content style more consistent with our docs! 🙌 I will also need to wait on platform to approve and release the feature before docs can be merged, so this PR is going to get a bunch of labels to help keep me organized. 😄

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jul 22, 2024
@sondr3 sondr3 closed this Sep 27, 2024
@sarah11918
Copy link
Member

Well, this is odd! @sondr3 I know I made an edit here originally, but it's probably not saved on GitHub. Is there any chance my commit still exists in your history somewhere?

I can re-edit to conform to our standards, but if I already did this once, it would be handy if that could just be applied here!

@sondr3
Copy link
Contributor Author

sondr3 commented Oct 2, 2024

I checked on my machine and I don't have anything besides my own commit sadly 😢

@sarah11918
Copy link
Member

@sondr3 No worries! Thank you for checking! I'll make some tiny edits today to just conform to our style, but wanted to wait just in case there was a history of what I'd already done!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience @sondr3 and @florian-lefebvre !

With some minor tweaking below, this is (once again?) perfectly fine! 😅

See my comment below re: a follow up. If there's something you want to sneak in before merging, it's fine by me. If this needs to merge more quickly, then it can be done as an add-on at any later point!

PS: I have committed directly these changes because it fixes our link error, but am still open to discussion if needed!

PPS: These docs won't be merged until the next minor release (next Thursday?) so there is certainly time to add something to these, if desired.

src/content/docs/en/guides/integrations-guide/sitemap.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/sitemap.mdx Outdated Show resolved Hide resolved
@sarah11918
Copy link
Member

Looks like this was released!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Oct 9, 2024
@sarah11918 sarah11918 merged commit 9e03e50 into withastro:main Oct 9, 2024
10 checks passed
@sondr3 sondr3 deleted the sitemap-xsl branch October 10, 2024 07:49
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Oct 11, 2024
…ro#8840

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
yanthomasdev pushed a commit that referenced this pull request Oct 11, 2024
…9643)

* i18n(fr): Update `guides/integrations-guide/sitemap.mdx` from #8840

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>

* Update src/content/docs/fr/guides/integrations-guide/sitemap.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/integrations-guide/sitemap.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/integrations-guide/sitemap.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/integrations-guide/sitemap.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

---------

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants