-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for xslURL in sitemap package #8840
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, @sondr3 ! The formatting and structure all looks great and you've integrated this content nicely into existing docs!
Just made a tiny edit to make the content style more consistent with our docs! 🙌 I will also need to wait on platform to approve and release the feature before docs can be merged, so this PR is going to get a bunch of labels to help keep me organized. 😄
Well, this is odd! @sondr3 I know I made an edit here originally, but it's probably not saved on GitHub. Is there any chance my commit still exists in your history somewhere? I can re-edit to conform to our standards, but if I already did this once, it would be handy if that could just be applied here! |
I checked on my machine and I don't have anything besides my own commit sadly 😢 |
@sondr3 No worries! Thank you for checking! I'll make some tiny edits today to just conform to our style, but wanted to wait just in case there was a history of what I'd already done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience @sondr3 and @florian-lefebvre !
With some minor tweaking below, this is (once again?) perfectly fine! 😅
See my comment below re: a follow up. If there's something you want to sneak in before merging, it's fine by me. If this needs to merge more quickly, then it can be done as an add-on at any later point!
PS: I have committed directly these changes because it fixes our link error, but am still open to discussion if needed!
PPS: These docs won't be merged until the next minor release (next Thursday?) so there is certainly time to add something to these, if desired.
Looks like this was released! |
…ro#8840 Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
…9643) * i18n(fr): Update `guides/integrations-guide/sitemap.mdx` from #8840 Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com> * Update src/content/docs/fr/guides/integrations-guide/sitemap.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu> * Update src/content/docs/fr/guides/integrations-guide/sitemap.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu> * Update src/content/docs/fr/guides/integrations-guide/sitemap.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu> * Update src/content/docs/fr/guides/integrations-guide/sitemap.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu> --------- Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Description
Add documentation for the new
xslURL
in@astrojs/sitemap
.