feat(sitemap): add xslURL to enable styling #11485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f1b4f08 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
ematipico
reviewed
Jul 18, 2024
bluwy
approved these changes
Jul 22, 2024
|
Sounds good to me. A fixture test is what I'd do. |
|
@sondr3 are you still interested in this PR? |
|
Sorry, didn't realize that action was needed on my end 😅 I'll get to writing a test |
|
@sondr3 are you still interested in this PR? |
|
Closing due to inactivity, if you'd like to keep working on this, please re-open. |
|
Yeah, sorry, started a new job and got a puppy so have been low on time. I'll reopen when I have time again 😃 |
florian-lefebvre
requested changes
Sep 30, 2024
florian-lefebvre
approved these changes
Oct 1, 2024
|
The code seems to be approved, but the docs aren't approved yet. Let's wait to merge the PR |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a
xslURLoption to the sitemap generator to enable styling of the generated sitemap(s).Testing
I haven't added tests yet as I didn't know whether to add a new unit test or create a new fixture, so figured I could create the PR and gather feedback.
Docs
withastro/docs#8840