-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint context API #1731
Add endpoint context API #1731
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hey, this looks great! I noticed that |
Yeah I saw
Yeah it's available now! I'll update this i the endpoint page 👍 |
Oh actually looks like there's the sentence in the endpoint docs:
So I think we don't need to add extra docs. I also pushed changes to add types and the code example for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bluwy! Made some suggestions following up on my review of withastro/astro#4986
I made some assumptions that were maybe wrong judging by your final addition here… If so, maybe we need to make a note to document getStaticPaths
in SSR which I didn’t think was supported.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Applied the suggestions. Thanks for the thorough review! |
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
What kind of changes does this PR include?
Description
New feature docs for withastro/astro#4986
Add API reference for endpoint context
The docs are pretty simple for now. Let me know if there's anything that can be improved!
Once the heading names are confirmed, I'll also update withastro/astro#4986 to have the JSDoc point to the anticipated link.