Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): Update of endpoints.md #1794

Merged
merged 9 commits into from
Oct 21, 2022
Merged

i18n(es): Update of endpoints.md #1794

merged 9 commits into from
Oct 21, 2022

Conversation

dreyfus92
Copy link
Member

@dreyfus92 dreyfus92 commented Oct 13, 2022 •
edited
Loading

What kind of changes does this PR include?

  • New or updated content
  • Translated content

Description

  • What does this PR change? Updated content according to this commit e56cbe9

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 13, 2022
@netlify
Copy link

netlify bot commented Oct 13, 2022 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 2b1703b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63525390b9c0ec00088da069
😎 Deploy Preview https://deploy-preview-1794--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dreyfus92 dreyfus92 changed the title i18n(es): endpoints.md updated i18n(es): Update of endpoints.md Oct 14, 2022
@sarah11918 sarah11918 added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 17, 2022
agustinmulet
agustinmulet reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@agustinmulet agustinmulet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisado! Cambié los links para el título propuesto por mi en este PR: #1804, decime si te parece bien 😄

src/pages/es/core-concepts/endpoints.md Outdated Show resolved Hide resolved
src/pages/es/core-concepts/endpoints.md Outdated Show resolved Hide resolved
@agustinmulet
Copy link
Contributor

También faltaría actualizar la indentación que se cambió en este commit 6b72121#diff-c4119b03e79e36340f6ce75858167fc04f8c2efe090c29bd800953964a08bb9d

agustinmulet
agustinmulet approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@agustinmulet agustinmulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although we need to merge this PR first to fix the link checker #1804

@agustinmulet
Copy link
Contributor

@dreyfus92 Please keep in mind that there were two commits that updated this file recently. Is it ok for you to make those changes so we keep everything up to date?
The commits are:

There are small changes 😄

@dreyfus92
Copy link
Member Author

Sure, will handle it in a few.

@agustinmulet
Copy link
Contributor

Lovely, LGTM!

delucis
delucis approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dreyfus92 and thanks @agustinmulet for keeping track of the updates!

@delucis delucis merged commit 8b9b269 into withastro:main Oct 21, 2022
@dreyfus92 dreyfus92 deleted the update-endpoints branch November 6, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@agustinmulet agustinmulet agustinmulet approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreyfus92 @agustinmulet @delucis @sarah11918