Support flags for astro add
#8032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg: astro
natemoo-re
force-pushed
the
feat/add-flags
branch
from
10248a6
to
404019f
Compare
🦋 Changeset detectedLatest commit: c763daf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦋 Changeset detectedLatest commit: 40d6322 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
commented
Aug 10, 2023
natemoo-re
commented
Aug 10, 2023
Comment on lines
+637
to
+644
| // Allow forwarding of standard `npm install` flags | ||
| // See https://docs.npmjs.com/cli/v8/commands/npm-install#description | ||
| const INHERITED_FLAGS = new Set<string>([ | ||
| "P", "save-prod", | ||
| "D", "save-dev", | ||
| "E", "save-exact", | ||
| "no-save", | ||
| ]) |
There was a problem hiding this comment.
Scoped these commands down to a hard-coded list!
natemoo-re
commented
Aug 10, 2023
| spinner.fail(); | ||
| debug('add', 'Error installing dependencies', err); | ||
| console.error('\n', (err as any).stdout, '\n'); |
There was a problem hiding this comment.
Added an error log here since the installation step can fail silently.
matthewp
approved these changes
Aug 10, 2023
bluwy
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
installflags forastro addTesting
Tested manually, it works!
Docs
Probably don't need to document this