Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astro add cli doesn't inherit flags #7793

Closed
1 task done
Elod-T opened this issue Jul 25, 2023 · 1 comment · Fixed by #8032
Closed
1 task done

astro add cli doesn't inherit flags #7793

Elod-T opened this issue Jul 25, 2023 · 1 comment · Fixed by #8032
Labels
- P2: nice to have Not breaking anything but nice to have (priority) feat: add Related to `astro add` CLI command (scope)

Comments

@Elod-T
Copy link
Contributor

Elod-T commented Jul 25, 2023

What version of astro are you using?

2.9.1

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm

What operating system are you using?

Linux

What browser are you using?

Chrome

Describe the Bug

With the astro add cli I you can install astro integrations and automatically add them to the config file. There are integrations that are only needed as devDependency but the cli doesn't provide a way to install them as one. ( For example astro-compress, astro-preload or @astrojs/sitemap )

astro-add

What's the expected result?

I would expect that the arguments get passed down to the install command.

Example:

2023-07-25_16-50

Link to Minimal Reproducible Example

any astro project

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jul 25, 2023
@natemoo-re
Copy link
Member

Thanks for opening an issue! I see that you already opened a PR, so we can continue the discussion there.

@natemoo-re natemoo-re added the - P2: nice to have Not breaking anything but nice to have (priority) label Aug 1, 2023
@github-actions github-actions bot removed the needs triage Issue needs to be triaged label Aug 1, 2023
@natemoo-re natemoo-re added the feat: add Related to `astro add` CLI command (scope) label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) feat: add Related to `astro add` CLI command (scope)
Projects
None yet
2 participants