Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs smoke error #5706

Merged
merged 25 commits into from
Jan 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
08623af
Fix docs smoke error
bluwy Dec 30, 2022
044aaea
Increase memory
bluwy Dec 30, 2022
8877513
wip: remove nanostores from NOEXTERNAL
bholmesdev Dec 30, 2022
aaf609b
temp: skip non-smoke ci jobs
bholmesdev Dec 30, 2022
d47ba97
chore: remove build temp from smoke
bholmesdev Dec 30, 2022
63afd8a
temp: only build docs on test:smoke
bholmesdev Dec 30, 2022
9e73a94
Revert "wip: remove nanostores from NOEXTERNAL"
bholmesdev Dec 30, 2022
f5ee799
temp: point to docs fork for debugging
bholmesdev Dec 30, 2022
052e2b0
temp: use smoke-debugging branch on fork
bholmesdev Dec 30, 2022
87c0343
temp: add external / noexternal log
bholmesdev Dec 30, 2022
0ecaa4e
temp: check '@babel/plugin-transform-react-jsx' resolves
bholmesdev Dec 30, 2022
98d5195
temp: remove double default
bholmesdev Dec 30, 2022
84a5622
temp: move babel jsx to top-level import
bholmesdev Dec 30, 2022
68af8f3
Revert "temp: move babel jsx to top-level import"
bholmesdev Dec 30, 2022
334b7a4
temp: log loaded renderers
bholmesdev Dec 30, 2022
d65dba6
temp: try node 16?
bholmesdev Dec 30, 2022
e66d7f8
Revert "temp: try node 16?"
bholmesdev Dec 30, 2022
be772ca
chore: remove deps log
bholmesdev Dec 30, 2022
c461265
chore: flip to ci-smoke-test branch
bholmesdev Dec 30, 2022
b7ef06a
chore: remove renderers log
bholmesdev Dec 30, 2022
f4ac308
fix: docs repo path
bholmesdev Dec 30, 2022
fcc7294
Try external preact integration
bluwy Jan 2, 2023
840ec85
Try nested default import
bluwy Jan 2, 2023
c2597e7
Add changeset
bluwy Jan 2, 2023
d5ee40f
Fix ci
bluwy Jan 2, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mean-knives-smash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Add preact and sitemap integration to config load external list
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -218,3 +218,5 @@ jobs:

- name: Test
run: pnpm run test:smoke
env:
NODE_OPTIONS: "--max-old-space-size=4096"
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"format:imports": "organize-imports-cli ./packages/*/tsconfig.json ./packages/*/*/tsconfig.json",
"test": "turbo run test --output-logs=new-only --concurrency=1 --filter=astro --filter=create-astro --filter=\"@astrojs/*\"",
"test:match": "cd packages/astro && pnpm run test:match",
"test:smoke": "turbo run build --filter=\"@example/*\" --filter=\"astro.build\" --filter=\"docs\" --output-logs=new-only --concurrency=1",
"test:smoke": "turbo run build --filter=\"@example/*\" --filter=\"docs\" --output-logs=new-only --concurrency=1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't look like a astro.build package to test so removed here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, there was an astro.build package but the checkout code was removed. We should add that back in a separate PR

"test:check-examples": "node ./scripts/smoke/check.js",
"test:vite-ci": "turbo run test --filter=astro --output-logs=new-only --no-deps --concurrency=1",
"test:e2e": "cd packages/astro && pnpm playwright install && pnpm run test:e2e",
Expand Down
8 changes: 7 additions & 1 deletion packages/astro/src/core/config/vite-load.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ async function createViteLoader(root: string, fs: typeof fsType): Promise<ViteLo
// NOTE: Vite doesn't externalize linked packages by default. During testing locally,
// these dependencies trip up Vite's dev SSR transform. In the future, we should
// avoid `vite.createServer` and use `loadConfigFromFile` instead.
external: ['@astrojs/tailwind', '@astrojs/mdx', '@astrojs/react'],
external: [
'@astrojs/tailwind',
'@astrojs/mdx',
'@astrojs/react',
'@astrojs/preact',
'@astrojs/sitemap',
],
},
plugins: [loadFallbackPlugin({ fs, root: pathToFileURL(root) })],
});
Expand Down