Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs smoke error #5706

Merged
merged 25 commits into from
Jan 2, 2023
Merged

Fix docs smoke error #5706

merged 25 commits into from
Jan 2, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 30, 2022

Changes

Add @astrojs/sitemap to ssr.external when loading config. It should be simplified when vitejs/vite#10939 lands.

Testing

Astro smoke test should pass.

Docs

n/a bug fix

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2022

🦋 Changeset detected

Latest commit: d5ee40f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 30, 2022
@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Dec 30, 2022
@github-actions github-actions bot added pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) labels Dec 30, 2022
@github-actions github-actions bot removed pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) labels Jan 2, 2023
"test:smoke": "turbo run build --filter=\"@example/*\" --filter=\"astro.build\" --filter=\"docs\" --output-logs=new-only --concurrency=1",
"test:smoke": "turbo run build --filter=\"@example/*\" --filter=\"docs\" --output-logs=new-only --concurrency=1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't look like a astro.build package to test so removed here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, there was an astro.build package but the checkout code was removed. We should add that back in a separate PR

@bluwy bluwy mentioned this pull request Jan 2, 2023
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smost excellent fix of 2023 👏

@bluwy bluwy merged commit c2844a7 into main Jan 2, 2023
@bluwy bluwy deleted the fix-smoke branch January 2, 2023 13:31
@astrobot-houston astrobot-houston mentioned this pull request Jan 2, 2023
@aFuzzyBear
Copy link
Contributor

Smost excellent fix of 2023 👏

... so far 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants