Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cloudflare #13150

Merged
merged 516 commits into from
Feb 7, 2025
Merged

Move cloudflare #13150

merged 516 commits into from
Feb 7, 2025

Conversation

ematipico
Copy link
Member

Changes

This PR moves the cloudflare adapter in the monorepo.

There was a test failing, which I updated. I left a TODO in cases we need to fix it.

Testing

CI should pass.

Docs

Will create a PR

astrobot-houston and others added 30 commits August 25, 2023 12:52
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* refactor: use new Astro internals

* chore: update tests

---------

Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Skip cloudflare CLI tests if fail to start

* Fix port

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* add necessary libs

* cleanup stale code

* add base feature-set of runtime to `astro dev`

* fix lockfile

* remove future code

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>

* remove future code

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>

* remove future code

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>

* remove future code

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>

* remove future code

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>

* address review comments

* fix linting issue

* add docs & tests

* fix test paths

* add changeset

* update README.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* fix docs & make adapter options optional

* fix package resolve mode

* fix pnpm-lock

---------

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ematipico and others added 22 commits November 28, 2024 12:10
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test: use Astro v5 and update cloudflare assertions

* disable check origin

* disable check origin

* update test

* fix another test

* remove logging

* format
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: bluwy <bjornlu.dev@gmail.com>
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 0063ecb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 7, 2025
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you merge main back into this it will remove all the changes to the Vercel adapter. Either than or run format. Otherwise, good to go

@ematipico
Copy link
Member Author

The changes to the Vercel adapter happened because I ran the formatter locally, and I didn't before 😅

@ematipico ematipico merged commit 3607b5b into main Feb 7, 2025
15 checks passed
@ematipico ematipico deleted the move-cloudflare branch February 7, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.