refactor: use new Astro internals #8254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
pkg: integration
ematipico
force-pushed
the
refactor/use-new-astro-internals
branch
from
280e7d4 to
1cb9a8a
Compare
matthewp
approved these changes
Aug 28, 2023
ematipico
added a commit
that referenced
this pull request
Feb 5, 2025
* refactor: use new Astro internals * chore: update tests --------- Co-authored-by: Matthew Phillips <matthew@skypack.dev>
ematipico
added a commit
that referenced
this pull request
Feb 5, 2025
* refactor: use new Astro internals * chore: update tests --------- Co-authored-by: Matthew Phillips <matthew@skypack.dev>
ematipico
added a commit
that referenced
this pull request
Feb 6, 2025
* refactor: use new Astro internals * chore: update tests --------- Co-authored-by: Matthew Phillips <matthew@skypack.dev>
ematipico
added a commit
that referenced
this pull request
Feb 7, 2025
* refactor: use new Astro internals * chore: update tests --------- Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR does some internal refactoring inside our supported adapters to use our new exported internals:
AstroErrorAstroIntegrationLoggerand theloggerreturned by the astro hooksI added the following APIs:
loggerto thepreviewAPI payload;getAdapterLogger, so the adapter runtime can do the same logging as astroI removed
runtime.ts, which was flagged as deprecated. There's aTODOto remove it for 3.0.Closes #8255
Testing
Current tests should all pass
Docs
N/A
I will probably follow up with another PR in the docs repo.