fix: make image endpoint highest priority #12591
Merged
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e8e5a78 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
florian-lefebvre
approved these changes
Dec 3, 2024
|
!preview image-endpoint |
Princesseuh
reviewed
Dec 3, 2024
| @@ -23,7 +23,7 @@ export function ensureImageEndpointRoute( | |||
| cwd?: string, | |||
| ) { | |||
| if (!manifest.routes.some((route) => route.route === '/_image')) { | |||
There was a problem hiding this comment.
oh, this condition is probably not good, you can change the path of the image endpoint. It should use the config to find the path.
There was a problem hiding this comment.
Good point. A different issue but we can include it in this
CodSpeed Performance ReportMerging #12591 will not alter performanceComparing Summary
|
ematipico
approved these changes
Dec 3, 2024
Princesseuh
approved these changes
Dec 3, 2024
ematipico
approved these changes
Dec 3, 2024
|
I'm going to wait til they pass in CI before merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensures that the image endpoint is highest priority, by adding it to the start of the route array rather than the end
Testing
Tested locally with repro site
Fixes #12589. Thanks @MathiasGmeiner
Docs