Skip to content

Commit

Permalink
fix: make image endpoint highest priority (#12591)
Browse files Browse the repository at this point in the history
* fix: make image endpoint highest priority

* Use config for endpoint

* Add test
  • Loading branch information
ascorbic authored Dec 3, 2024
1 parent 3a144b1 commit b731b3d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/plenty-carrots-nail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes a bug where a catchall route would match an image endpoint request
6 changes: 3 additions & 3 deletions packages/astro/src/assets/endpoint/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export function injectImageEndpoint(
mode: 'dev' | 'build',
cwd?: string,
) {
manifest.routes.push(getImageEndpointData(settings, mode, cwd));
manifest.routes.unshift(getImageEndpointData(settings, mode, cwd));
}

export function ensureImageEndpointRoute(
Expand All @@ -22,8 +22,8 @@ export function ensureImageEndpointRoute(
mode: 'dev' | 'build',
cwd?: string,
) {
if (!manifest.routes.some((route) => route.route === '/_image')) {
manifest.routes.push(getImageEndpointData(settings, mode, cwd));
if (!manifest.routes.some((route) => route.route === settings.config.image.endpoint.route)) {
manifest.routes.unshift(getImageEndpointData(settings, mode, cwd));
}
}

Expand Down

0 comments on commit b731b3d

Please sign in to comment.