Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): better runtime check for invalid usages #12402

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

ematipico
Copy link
Member

Changes

Closes #12393
Closes PLT-2625

The user code was invalid, but Astro didn't catch it. Now it does

Testing

Added a new test case

Docs

N/A

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 9264811

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 8, 2024
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #12402 will not alter performance

Comparing fix/astro-actions-error (d3e0794) with main (f5f7109)

Summary

✅ 1 untouched benchmarks

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check yourself before you wreck yourself

packages/astro/test/actions.test.js Show resolved Hide resolved
packages/astro/src/actions/runtime/virtual/server.ts Outdated Show resolved Hide resolved
@ematipico ematipico merged commit 823e73b into main Nov 8, 2024
15 checks passed
@ematipico ematipico deleted the fix/astro-actions-error branch November 8, 2024 15:55
@astrobot-houston astrobot-houston mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context not available in astro:actions
3 participants