Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on desktop tests again #231

Closed
wants to merge 12 commits into from
2 changes: 1 addition & 1 deletion .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
- name: Run visual regression
shell: 'script -q -e -c "bash {0}"'
run: |
script -e -c "./pixel.js reference -g mobile && ./pixel.js test -g mobile"
script -e -c "./pixel.js reference && ./pixel.js test"
10 changes: 5 additions & 5 deletions Dockerfile.a11y-regression
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ RUN set -ex && \
if [ "$ARCH" = "x86_64" ]; then \
sudo npm install -g --unsafe-perm=true --allow-root pa11y@${PA11Y_VERSION}; \
else \
sudo PUPPETEER_SKIP_DOWNLOAD=true PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true npm install -g --unsafe-perm=true --allow-root pa11y@${PA11Y_VERSION} && puppeteer-chromium-version-finder@^1.0.1 chromium-version-deb-finder@^2.0.1 && \
NODE_PATH="$(npm root -g):$(npm root -g)/backstopjs/node_modules" node -e " \
sudo PUPPETEER_SKIP_DOWNLOAD=true PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true npm install -g --unsafe-perm=true --allow-root pa11y@${PA11Y_VERSION} puppeteer@21.7.0 puppeteer-chromium-version-finder@^1.0.1 chromium-version-deb-finder@^2.0.1 && \
NODE_PATH="$(npm root -g):$(npm root -g)/puppeteer/node_modules" node -e " \
const versionFinder = require('puppeteer-chromium-version-finder'); \
const debFinder = require('chromium-version-deb-finder'); \
(async () => { \
Expand All @@ -32,8 +32,6 @@ RUN set -ex && \
sudo test -f /usr/bin/chromium && sudo ln -s /usr/bin/chromium /usr/bin/chromium-browser && sudo ln -s /usr/bin/chromium /usr/bin/chrome; \
fi

RUN sudo npm install -g mustache

RUN wget https://dl-ssl.google.com/linux/linux_signing_key.pub && sudo apt-key add linux_signing_key.pub
RUN sudo add-apt-repository "deb http://dl.google.com/linux/chrome/deb/ stable main"

Expand All @@ -52,7 +50,9 @@ RUN apt-get -qqy update \
&& rm -rf /var/lib/apt/lists/* \
&& apt-get -qyy clean

RUN sudo npm install -g mustache

ENV NODE_PATH=/usr/local/lib/node_modules

#ENTRYPOINT ["tail", "-f", "/dev/null"]
ENTRYPOINT ["node", "src/a11y/runA11yTests.js"]
ENTRYPOINT ["node", "src/a11y/runA11yTests.js"]
5 changes: 0 additions & 5 deletions LocalSettings.php
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,3 @@

$wgMFAmcOutreachMinEditCount = 0;
$wgMFAmcOutreach = true;
$wgVectorZebraDesign = [
"logged_in" => true,
"logged_out" => true,
"beta" => true,
];
Loading