Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI on desktop tests again #231

Closed
wants to merge 12 commits into from
Closed

Run CI on desktop tests again #231

wants to merge 12 commits into from

Conversation

jdlrobson
Copy link
Member

@jdlrobson jdlrobson commented Jan 10, 2024 •
edited
Loading

I temporarily switched Pixel over to the mobile tests to unblock CI.
I am not sure what's wrong with CI in desktop but am hoping we'll be able to replicate this on https://pixel.wmcloud.org/ at least!

moabualruz and others added 3 commits January 9, 2024 19:41
@moabualruz
Fix A11y arm image
7600756 
- depend on prebuilt backstop image
- reduce redundant code
@moabualruz
Fix A11y arm image
06134fb 
- depend on backstop image
@jdlrobson
Run CI on desktop tests
49a4287
@jdlrobson jdlrobson changed the title Run CI on desktop tests Run CI on desktop tests again Jan 10, 2024
@jdlrobson
Copy link
Member Author

@moabualruz Failures likely have something to do with:

ProtocolError: Protocol error (Runtime.callFunctionOn): Target closed.
    at /usr/local/lib/node_modules/backstopjs/node_modules/puppeteer/lib/cjs/puppeteer/common/Connection.js:278:24
    at new Promise (<anonymous>)
    at CDPSession.send (/usr/local/lib/node_modules/backstopjs/node_modules/puppeteer/lib/cjs/puppeteer/common/Connection.js:274:16)
    at ExecutionContext._ExecutionContext_evaluate (/usr/local/lib/node_modules/backstopjs/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:268:46)
    at ExecutionContext.evaluateHandle (/usr/local/lib/node_modules/backstopjs/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:162:107)
    at WaitTask.rerun (/usr/local/lib/node_modules/backstopjs/node_modules/puppeteer/lib/cjs/puppeteer/common/DOMWorld.js:664:37)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

jdlrobson and others added 3 commits January 9, 2024 20:47
@jdlrobson
Scroll to a fixed number
f98336f 
Perhaps the reliance on window.innerHeight is the problem?
@moabualruz
Fix A11y arm image
a9c007b 
- Fix the pa11y package installation on docker arm image
@moabualruz
Fix A11y arm image
ded8512 
- Fix the pa11y package installation on docker arm image
- Add pa11y to package.json dependencies
moabualruz
moabualruz requested changes Jan 10, 2024
View reviewed changes
@moabualruz
Fix A11y arm image
158747e 
- Fix the pa11y package installation on docker arm image
- Add pa11y to package.json dependencies
@moabualruz
Copy link
Collaborator

With client preferences the toggle process is different this needs updating, this is the unfound target

@moabualruz moabualruz changed the base branch from main to Arm-Fixes January 10, 2024 17:28
moabualruz
moabualruz reviewed Jan 10, 2024
View reviewed changes
@moabualruz moabualruz self-requested a review January 10, 2024 17:48
@moabualruz moabualruz changed the base branch from Arm-Fixes to main January 10, 2024 17:50
@jdlrobson jdlrobson marked this pull request as draft January 10, 2024 18:11
@moabualruz moabualruz self-requested a review January 10, 2024 18:13
@jdlrobson jdlrobson closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabualruz moabualruz Awaiting requested review from moabualruz

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdlrobson @moabualruz