Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable noisy security lints in client code #574

Closed
edg2s opened this issue May 20, 2024 · 2 comments · Fixed by #575
Closed

Disable noisy security lints in client code #574

edg2s opened this issue May 20, 2024 · 2 comments · Fixed by #575

Comments

@edg2s
Copy link
Member

edg2s commented May 20, 2024

Most of our unresolved warnings and inline disables come from security warnings around regular expressions. AFAICT this represent a possible sources of very slow code, but not big security concerns as they may do in server side code.

@edg2s
Copy link
Member Author

edg2s commented May 20, 2024

These rules produced dozens of warnings in VE, for example.

cc @sbassett29 @MatmaRex

@sbassett29
Copy link
Member

Fine with me to disable if they're proving to be more of a hindrance than helpful. Most true ReDoSes are going to be fairly difficult to exploit within much of our JS code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants