client/common: Disable regex security checks

Fixes #574
wikimedia · May 20, 2024 · 32e215a · 32e215a
1 parent 1e8adec
commit 32e215a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/client/common.json b/client/common.json
@@ -11,6 +11,8 @@
 		"no-console": "error",
 		"no-implied-eval": "error",
 		"unicorn/no-invalid-remove-event-listener": "error",
+		"security/detect-non-literal-regexp": "off",
+		"security/detect-unsafe-regex": "off",
 		"security/detect-possible-timing-attacks": "off"
 	}
 }
diff --git a/test/fixtures/client/common/valid.js b/test/fixtures/client/common/valid.js
@@ -1,4 +1,4 @@
-( function () {
+( function ( userInput ) {
 	function checkHash( input, cachedValue ) {
 		var hash = JSON.stringify( input );
 		// Off: security/detect-possible-timing-attacks (#503)
@@ -7,5 +7,11 @@
 		}
 	}
 
-	checkHash();
+	checkHash(
+		// Off: security/detect-non-literal-regexp
+		new RegExp( '/[0-9]+' + userInput + '/' ),
+		// Off: security/detect-unsafe-regex
+		/^([a-zA-Z0-9_.-])+@(([a-zA-Z0-9-])+\.)+([a-zA-Z0-9]{2,4})+$/
+	);
+
 }() );