limit churn by commits within the last year #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natesholland
changed the title
|
Seems reasonable to me. The Churn gem (in which I based the Churn Analyser), only takes into account the first 3 months when calculating churn. However, it provides an option to configure that date range. I think this is the same use case and as such should be configurable. Guess I gotta start working on #30... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think limiting the church calculations by 1 year seems reasonable, and greatly speeds up the calculation time for really old projects. Also I think from a metric perspective it makes sense, churn that is over 1 year old doesn't seem like a valuable thing to pay attention to in my mind.