Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings file #30

Open
davidgomes opened this issue Feb 26, 2015 · 9 comments
Open

Settings file #30

davidgomes opened this issue Feb 26, 2015 · 9 comments
Labels
feature good first issue Hacktoberfest https://hacktoberfest.digitalocean.com

Comments

@davidgomes
Copy link

Instead of having settings purely as flags, it would be interesting to have a configuration file, which could be ported and used across several projects.

@natesholland
Copy link
Contributor

I agree, I think a rubycritic.yml file would be a good candidate for how we handle settings.

@bglusman
Copy link
Contributor

In debt_ceiling I use the Confirguations gem, and read in a ruby file with rails like configuration block... I think I prefer that to yml, but agree having settings/config is a good idea.

@johnkelly
Copy link

+1. It would be great to specify in a config file which folders ruby critic should critique.

@troessner
Copy link
Contributor

Agree, would be useful. Would somebody like to take a stab at this? ;)

@troessner
Copy link
Contributor

The same comment I wrote for #11 applies here:

Due to RC's nature this is not really trivial since we aggregate multiple tools and those tools have a different understanding of how you can exclude and include paths. And some might not even offer an "exclude" functionality.
Nevertheless I can see that this feature would be highly valuable.

;)

@nav16
Copy link
Contributor

nav16 commented Nov 26, 2016

I am working on this, using yml (rubycritic.yml) file.

@westlakem
Copy link
Contributor

@nav16 Any updates on this? I have a project right now where we patch a gem and it is very picky about how we patch it. This file is the only thing that's not an 'A' and is keeping me from doing a -s 100 on our ci build

@grantneufeld
Copy link

It would be nice if the rubycritic config was basically just an extended version of the Reek config — so we could copy our current Reek configuration into it, and add other configuration options for the other tools (flog, flay, etc.) and for rubycritic itself.

Or maybe provide a rubycritic config directory that can contain config files specific to each tool (e.g., .rubycritic/.reek).

In particular, I want to be able to configure skipping some of the checks from Flog and Flay (e.g., HighComplexity, DuplicateCode) for specific directories (e.g., spec), without having to ignore those directories for everything else.

Right now, my rubycritic my report gets filled up with lots of complexity and duplicate code smells from my spec directory, unless I don’t include the spec directory (and miss out on reporting the code smells I do want to see for specs).

Thanks!

@nunosilva800 nunosilva800 added the Hacktoberfest https://hacktoberfest.digitalocean.com label Oct 24, 2019
@piacsek
Copy link

piacsek commented May 30, 2022

I guess this can be closed, since we can use .reek.yml as a configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Hacktoberfest https://hacktoberfest.digitalocean.com
Projects
None yet
Development

No branches or pull requests