Cache for profile #134
Merged
Cache for profile #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependent on upstream PR <whisperfish/libsignal-service-rs#207>. This is very similar to <whisperfish#130> and provides pretty much the same functionality for profiles. Maybe after both are merged, a function `clear_cache` would be useful for the stores.
|
Thanks for the PR! There's no obvious way to force the refresh of profile is we do it like this, but it's already better than nothing as it avoids rate-limiting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on upstream PR whisperfish/libsignal-service-rs#207. Therefore, my fork is currently uses but should be changed to upstream as soon as merged there.This is very similar to #130 and provides pretty much the same functionality for profiles.
Maybe after both are merged, a function
clear_cachewould be useful for the stores.