Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment Store for caching attachments #130

Closed
wants to merge 2 commits into from
Closed

Attachment Store for caching attachments #130

wants to merge 2 commits into from

Conversation

Schmiddiii
Copy link
Contributor

This enables caching of attachments. Some notes:

  • This assumes an AttachmentIdentifier of an AttachmentPointer uniquely references an attachment which may not change.
  • We may also want to cache attachments when uploading.
  • We may also want a method checking if there is a local version of the attachment.
  • We probably want something to delete old attachments (similar to LRU-cache). Not yet sure how this can be implemented, but maybe one could add the timestamp of the save to the stored attachment and then iterate over all attachments (O(n)) and delete the old ones.

Schmiddiii added a commit to Schmiddiii/presage that referenced this pull request Mar 18, 2023
@Schmiddiii
Cache for profile
c69319f 
Dependent on upstream PR <whisperfish/libsignal-service-rs#207>.

This is very similar to
<whisperfish#130> and provides pretty
much the same functionality for profiles.

Maybe after both are merged, a function `clear_cache` would be useful
for the stores.
@Schmiddiii Schmiddiii mentioned this pull request Mar 18, 2023
Merged
@gferon gferon added this to the 0.6.0 milestone Apr 21, 2023
@Schmiddiii
Copy link
Contributor Author

I feel like this pR is too outdated with the current main branch. Even though this is still something I want some day, I think it is better to close this PR and redo it on a later day.

@Schmiddiii Schmiddiii closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Schmiddiii @gferon