test_result_logger: accept release version numbers #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening your first pull request here! 💖 |
When building on release, the output version is e.g. 0.8.0, without dev part. Thus, this commit makes the dev part optional, allowing it to match both cases. Fixes GH-420. Signed-off-by: Bruno Pagani <bruno.n.pagani@gmail.com>
ArchangeGabriel
commented
Oct 31, 2019
Freso
requested changes
Oct 31, 2019
|
Ideally there should be at least four test cases, one for each of the situations described at https://github.com/pypa/setuptools_scm/#default-versioning-scheme |
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
|
@Freso @ArchangeGabriel I think the following RegEX matches all the (4) cases: [\d]+\.[\d]+\.[\d]+(\+d\d{8}|\.dev[\w\.\+]+)? \(internal logger\) |
hydrian
pushed a commit
to hydrian/whipper
that referenced
this pull request
Dec 18, 2019
Initial work by ArchangeGabriel: whipper-team#421 Fixes whipper-team#420. Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com> Signed-off-by: hydrian <ben.tyger@tygerclan.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on release, the output version is e.g. 0.8.0, without dev part.
Thus, this commit makes the dev part optional, allowing it to match both cases.
Fixes GH-420.