Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Whipper's version RegEX: support all valid scheme cases
Initial work by ArchangeGabriel: #421 Fixes #420. Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
- Loading branch information
d5bf83e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test doesn’t actually test all four cases though, it just makes the current .log file not break. We should have 3 additional .log files in addition to
test_result_logger.log
which the version string being formatted differently in each and test each of those. (Or have a separate function to test the version string so we could unit test it with values directly, without having to parse a whole .log file…)d5bf83e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this is just the first step. I've done it this way to quickly solve #420 (only issue left assigned to milestone 0.9.0).
EDIT: Just opened an issue about this: #427.