Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pass strings into component compiling steps #214

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

jeremyroman
Copy link
Collaborator

@jeremyroman jeremyroman commented Jan 26, 2024

Currently, some steps in "initialize a URLPattern" access potentially nonexistent entries in the processedInit map, and expect "compile a component" to receive these as null, even though it requires a string.

Instead, these entries are now always populated after calling "process a URLPatternInit" so that subsequent steps can depend on a valid string.

Since the comparison with the default port requires that the two types be the same, fix that too.

Fixes #209.

  • At least two implementers are interested (and none opposed):
    • Google Chrome
    • n/a (change is simply fixing a bug in a non-controversial way, per this comment)
  • Tests are written and can be reviewed and commented upon at:
    • n/a (this is a fix to how the spec expresses this, but does not represent a behavior change, and existing tests cover this behavior)
  • Implementation bugs are filed:
    • Chromium: n/a (believed to work correctly in Chromium)
    • Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1731418 (vendor does not yet implement the spec)
    • WebKit: [no known URLPattern bug] (vendor does not yet implement the spec)
    • Deno: n/a (no reason to believe a change is required)
    • kenchris/urlpattern-polyfill: n/a (no reason to believe a change is required)
  • MDN issue is filed: n/a (change is on a spec detail not expressly documented)
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


💥 Error: 400 Bad Request 💥

PR Preview failed to build. (Last tried on Jan 26, 2024, 8:28 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Copy link
Collaborator

@sisidovski sisidovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for handling this.

@jeremyroman jeremyroman merged commit ddd41db into whatwg:main Jan 30, 2024
2 checks passed
@jeremyroman jeremyroman deleted the processedinit-absent branch January 30, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"Hostname pattern is an IPv6 address" called with null
2 participants