Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct processing of non-string members of a base URL record #203

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

jeremyroman
Copy link
Collaborator

@jeremyroman jeremyroman commented Jan 12, 2024

Some of these values may be null (or in the case of port, an integer) and
must be converted to strings before they can be applied to URLPatternInit.

The conversion of the port to an integer is also necessary in the encoding
callbacks.

Addresses #202, at least in part.

  • At least two implementers are interested (and none opposed):
    • Google Chrome
    • n/a (change is simply fixing a bug in a non-controversial way)
  • Tests are written and can be reviewed and commented upon at:
    • n/a (this is a fix to how the spec expresses this, but does not represent a behavior change, and existing tests cover this behavior)
  • Implementation bugs are filed:
    • Chromium: n/a (believed to work correctly in Chromium)
    • Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1731418 (vendor does not yet implement the spec)
    • WebKit: [no known URLPattern bug] (vendor does not yet implement the spec)
    • Deno: n/a (no reason to believe a change is required)
    • kenchris/urlpattern-polyfill: n/a (no reason to believe a change is required)
  • MDN issue is filed: n/a (change is on a spec detail not expressly documented)
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@jeremyroman jeremyroman changed the title Correct processing of non-integer members of a base URL record Correct processing of non-string members of a base URL record Jan 12, 2024
Some of these values may be null (or in the case of port, an integer)
and must be converted to strings before they can be applied to
URLPatternInit.

Fixes whatwg#202.
Copy link
Collaborator

@sisidovski sisidovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for taking this!

@jeremyroman
Copy link
Collaborator Author

@annevk I think we need a second implementer interest even for little fixes like this, right? Is WebKit cool with this?

@annevk
Copy link
Member

annevk commented Jan 16, 2024

I think for cases where you are just fixing a bug in the standard when there are no conflicting implementations out there you can use your best judgment and carry on.

Though perhaps the extra waiting time helps as I see you fixed another another nit. :-)

Anyway, looks good.

@jeremyroman
Copy link
Collaborator Author

Thanks Anne, noted for future changes in this vein.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants