Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First class source sink objects #265

Merged
merged 3 commits into from
Jan 22, 2015
Merged

First class source sink objects #265

merged 3 commits into from
Jan 22, 2015

Commits on Jan 21, 2015

  1. Call underlying source functions as methods 

    Part of #256. This also removes the concept of the "default readable stream strategy" in favor of incorporating the defaults into the algorithms directly.
    @domenic
    domenic committed Jan 21, 2015
    Configuration menu
    Copy the full SHA
    1b20896 View commit details
    Browse the repository at this point in the history

  2. Call underlying sink functions as methods. 

    Closes #256. As with the previous commit for readable streams, removes the idea of a default writable stream queuing strategy in favor of just incorporating the fallbacks into the algorithms directly.
    @domenic
    domenic committed Jan 21, 2015
    Configuration menu
    Copy the full SHA
    e190bca View commit details
    Browse the repository at this point in the history

  3. Add tests for the new source/sink error cases 

    The previous commits introduced many new places that we call in to user code, since we no longer validate that we are grabbing functions and then store them, but instead extract and invoke methods every time. This commit adds tests for a variety of pathological inputs, to ensure that the errors they throw are propagated or caught-and-exposed, as appropriate.
    @domenic
    domenic committed Jan 21, 2015
    Configuration menu
    Copy the full SHA
    7676d81 View commit details
    Browse the repository at this point in the history