First class source sink objects #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
force-pushed
the
first-class-source-sink-objects
branch
from
5b8fa9f
to
959fc4e
Compare
| @@ -1308,52 +1274,47 @@ Instances of <code>WritableStream</code> are created with the internal slots des | |||
| <h4 id="ws-constructor">new WritableStream({ start, write, close, abort, strategy } = {})</h4> | |||
There was a problem hiding this comment.
Should the title be also modified, for the symmetry with ReadableStream?
There was a problem hiding this comment.
Yes, good catch, thank you! This actually has normative consequences, as we no longer do destructuring into functions, but instead preserve the whole object.
domenic
force-pushed
the
first-class-source-sink-objects
branch
from
959fc4e
to
787d1c6
Compare
Part of #256. This also removes the concept of the "default readable stream strategy" in favor of incorporating the defaults into the algorithms directly.
Closes #256. As with the previous commit for readable streams, removes the idea of a default writable stream queuing strategy in favor of just incorporating the fallbacks into the algorithms directly.
The previous commits introduced many new places that we call in to user code, since we no longer validate that we are grabbing functions and then store them, but instead extract and invoke methods every time. This commit adds tests for a variety of pathological inputs, to ensure that the errors they throw are propagated or caught-and-exposed, as appropriate.
domenic
force-pushed
the
first-class-source-sink-objects
branch
from
787d1c6
to
7676d81
Compare
tyoshino
added a commit
that referenced
this pull request
Feb 10, 2015
Porting #265 to ReadableByteStream
tyoshino
added a commit
that referenced
this pull request
Feb 10, 2015
Porting #265 to ReadableByteStream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256 (/cc @jkrems).
Could use some careful review as the changes were pretty wide-ranging. I am not too worried about the algorithms---the reference implementation and its extensive test suite help with my confidence there---but the editorial changes always leave the potential for pointers, "dead code", etc.
Preview at https://streams.spec.whatwg.org/branch-snapshots/first-class-source-sink-objects/