Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onslotchange #4129

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Add onslotchange #4129

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5a5a1c
Add onslotchange
annevk Oct 26, 2018
acc0390
let's remove this as HTML doesn't define when this dispatches and it …
annevk Oct 26, 2018
9873253
Put it back
domenic Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11583,6 +11583,7 @@ https://software.hixie.ch/utilities/js/live-dom-viewer/?%3C%21DOCTYPE%20HTML%3E%
<li><code data-x="handler-onseeked">onseeked</code></li>
<li><code data-x="handler-onseeking">onseeking</code></li>
<li><code data-x="handler-onselect">onselect</code></li>
<li><code data-x="handler-onslotchange">onslotchange</code></li>
<li><code data-x="handler-onstalled">onstalled</code></li>
<li><code data-x="handler-onsubmit">onsubmit</code></li>
<li><code data-x="handler-onsuspend">onsuspend</code></li>
Expand Down Expand Up @@ -90629,6 +90630,7 @@ typedef <span>OnBeforeUnloadEventHandlerNonNull</span>? <dfn>OnBeforeUnloadEvent
<tr><td><dfn data-export="" data-dfn-type="attribute" data-dfn-for="HTMLElement,Document,Window,GlobalEventHandlers"><code data-x="handler-onseeked">onseeked</code></dfn> <td> <code data-x="event-media-seeked">seeked</code>
<tr><td><dfn data-export="" data-dfn-type="attribute" data-dfn-for="HTMLElement,Document,Window,GlobalEventHandlers"><code data-x="handler-onseeking">onseeking</code></dfn> <td> <code data-x="event-media-seeking">seeking</code>
<tr><td><dfn data-export="" data-dfn-type="attribute" data-dfn-for="HTMLElement,Document,Window,GlobalEventHandlers"><code data-x="handler-onselect">onselect</code></dfn> <td> <code data-x="event-select">select</code> <!-- widely used --> <!-- [CSSOM] -->
<tr><td><dfn data-export="" data-dfn-type="attribute" data-dfn-for="HTMLElement,Document,Window,GlobalEventHandlers"><code data-x="handler-onslotchange">onslotchange</code></dfn> <td> <code data-x="event-slotchange">slotchange</code>
<tr><td><dfn data-export="" data-dfn-type="attribute" data-dfn-for="HTMLElement,Document,Window,GlobalEventHandlers"><code data-x="handler-onstalled">onstalled</code></dfn> <td> <code data-x="event-media-stalled">stalled</code>
<tr><td><dfn data-export="" data-dfn-type="attribute" data-dfn-for="HTMLElement,Document,Window,GlobalEventHandlers"><code data-x="handler-onsubmit">onsubmit</code></dfn> <td> <code data-x="event-submit">submit</code> <!-- widely used -->
<tr><td><dfn data-export="" data-dfn-type="attribute" data-dfn-for="HTMLElement,Document,Window,GlobalEventHandlers"><code data-x="handler-onsuspend">onsuspend</code></dfn> <td> <code data-x="event-media-suspend">suspend</code>
Expand Down Expand Up @@ -90812,6 +90814,7 @@ typedef <span>OnBeforeUnloadEventHandlerNonNull</span>? <dfn>OnBeforeUnloadEvent
attribute <span>EventHandler</span> <span data-x="handler-onseeked">onseeked</span>;
attribute <span>EventHandler</span> <span data-x="handler-onseeking">onseeking</span>;
attribute <span>EventHandler</span> <span data-x="handler-onselect">onselect</span>;
attribute <span>EventHandler</span> <span data-x="handler-onslotchange">onslotchange</span>;
attribute <span>EventHandler</span> <span data-x="handler-onstalled">onstalled</span>;
attribute <span>EventHandler</span> <span data-x="handler-onsubmit">onsubmit</span>;
attribute <span>EventHandler</span> <span data-x="handler-onsuspend">onsuspend</span>;
Expand Down Expand Up @@ -119897,6 +119900,12 @@ interface <dfn>External</dfn> {
<td> <code data-x="event-select">select</code> event handler
<td> <span data-x="event handler content attributes">Event handler content attribute</span>

<tr>
<th id="ix-handler-onslotchange"> <code data-x="">onslotchange</code>
<td> <span data-x="handler-onslotchange">HTML elements</span>
<td> <code data-x="event-slotchange">slotchange</code> event handler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really seems like some spec should define this. Is the plan for DOM to do so? Should we wait on that before merging this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah maybe? I'm not entirely clear on the purpose of this. Note that it's an index, a rather strange place for a dfn.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it mostly just gives a centralized place for everything to link to. I agree it's not quite a definition in the usual sense, but, it still seems good to have.

If there's a definition in DOM I think it could use a different format, not the HTML one. But one should probably exist; it feels weird otherwise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really seems like some spec should define this. Is the plan for DOM to do so? Should we wait on that before merging this?

Yeah maybe? I'm not entirely clear on the purpose of this. Note that it's an index, a rather strange place for a dfn.

I think it mostly just gives a centralized place for everything to link to.

Right. Along with links among specs, it also gives MDN docs something to link to

I agree it's not quite a definition in the usual sense, but, it still seems good to have.

Yeah. Though I guess an alternative would just to rely on an ID on the element

<td> <span data-x="event handler content attributes">Event handler content attribute</span>

<tr>
<th id="ix-handler-onstalled"> <code data-x="">onstalled</code>
<td> <span data-x="handler-onstalled">HTML elements</span>
Expand Down Expand Up @@ -120677,6 +120686,12 @@ INSERT INTERFACES HERE
<td> Form controls
<td> Fired at form controls when their text selection is adjusted (whether by an API or by the user)

<tr> <!-- slotchange -->
<td> <dfn data-dfn-type="event" data-dfn-for="HTMLSlotElement" data-export=""><code data-x="event-slotchange">slotchange</code></dfn>
<td> <code>Event</code>
<td> <code>slot</code> elements
<td> Fired at <code>slot</code> elements when their <span>assigned nodes</span> change

<tr> <!-- storage -->
<td> <dfn data-dfn-type="event" data-dfn-for="Window" data-export=""><code data-x="event-storage">storage</code></dfn>
<td> <code>StorageEvent</code>
Expand Down