Add onslotchange #4129

annevk · 2018-10-26T10:09:13Z

Tests: ...

/dom.html ( diff )
/indices.html ( diff )
/webappapis.html ( diff )

Tests: ... Fixes #3487.

…doesn't really have a suitable dfn

domenic · 2018-10-26T12:37:06Z

source

+    <tr>
+     <th id="ix-handler-onslotchange"> <code data-x="">onslotchange</code>
+     <td> <span data-x="handler-onslotchange">HTML elements</span>
+     <td> <code data-x="">slotchange</code> event handler


It really seems like some spec should define this. Is the plan for DOM to do so? Should we wait on that before merging this?

Yeah maybe? I'm not entirely clear on the purpose of this. Note that it's an index, a rather strange place for a dfn.

I think it mostly just gives a centralized place for everything to link to. I agree it's not quite a definition in the usual sense, but, it still seems good to have.

If there's a definition in DOM I think it could use a different format, not the HTML one. But one should probably exist; it feels weird otherwise.

It really seems like some spec should define this. Is the plan for DOM to do so? Should we wait on that before merging this?

Yeah maybe? I'm not entirely clear on the purpose of this. Note that it's an index, a rather strange place for a dfn.

I think it mostly just gives a centralized place for everything to link to.

Right. Along with links among specs, it also gives MDN docs something to link to

I agree it's not quite a definition in the usual sense, but, it still seems good to have.

Yeah. Though I guess an alternative would just to rely on an ID on the element

domenic · 2019-09-19T05:18:07Z

This will automatically be tested by https://github.com/web-platform-tests/wpt/blob/master/html/webappapis/scripting/events/event-handler-all-global-events.html and https://github.com/web-platform-tests/wpt/blob/master/html/webappapis/scripting/events/resources/event-handler-body.js once the IDL lands in the spec. So, this is ready to go from my perspective. (I put back the definition of the event which was previously discussed.)

I will approve, but @annevk, can you confirm you are OK with putting the event definition back?

annevk · 2019-09-20T02:36:32Z

Seems okay. I guess DOM should also be updated to point to this once this lands. We probably also need implementation bugs right?

annevk · 2019-09-20T02:38:30Z

The original issue also talked about ShadowRoot. Is that still a thing we want to do?

domenic · 2019-09-20T03:47:31Z

That still seems reasonable, I think?

domenic · 2019-09-20T03:53:29Z

Bugs:

This introduces it to ShadowRoot in addition to GlobalEventHandlers, as a counterpart to whatwg/html#4129. Closes whatwg/html#3487.

https://bugs.webkit.org/show_bug.cgi?id=191310 Patch by Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> on 2020-10-03 Reviewed by Sam Weinig. LayoutTests/imported/w3c: Rebaselined tests to pass more test cases. * web-platform-tests/dom/idlharness.window-expected.txt: * web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events-expected.txt: * web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt: * web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-windowless-body-expected.txt: * web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Source/WebCore: `onslotchange` attribute has been added to `ShadowRoot` and `GlobalEventHandlers` by whatwg/html#3487 - whatwg/dom#78 - whatwg/html#4129 This patch supports it. Tests: imported/w3c/web-platform-tests/dom/idlharness.window.html: imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events.html imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window.html imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative.html * dom/GlobalEventHandlers.idl: * dom/ShadowRoot.idl: * html/HTMLAttributeNames.in: * html/HTMLElement.cpp: (WebCore::HTMLElement::createEventHandlerNameMap): LayoutTests: Rebaselined tests to pass more test cases. * platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: * platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: * platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reflects following spec changes: - whatwg/html#4129 - whatwg/dom#785 Those new spec addition is already implemented in Safari and Chromium is working on it. Differential Revision: https://phabricator.services.mozilla.com/D123775

`onslotchange` IDL attribute is supported by interfaces: - GlobalEventHandlers [1] - ShadowRoot [2] Reflects following spec changes: - whatwg/html#4129 - whatwg/dom#785 Those new spec addition is already implemented in Safari and Gecko[3]. Intent to Ship mail with 3 approvals: [4] [1] https://html.spec.whatwg.org/#globaleventhandlers [2] https://dom.spec.whatwg.org/#interface-shadowroot [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1501983 [4] https://groups.google.com/a/chromium.org/g/blink-dev/c/cagoIboJ6Oo/m/roPoRAEDBAAJ R=fwang@igalia.com, rego@igalia.com Bug: 1006096 Change-Id: I3d0d7eb437aba3e40d24cca9bcf31d1db701f970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3096889 Commit-Queue: SONIA SINGLA <ssingla@igalia.com> Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Manuel Rego <rego@igalia.com> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/main@{#931541}

`onslotchange` IDL attribute is supported by interfaces: - GlobalEventHandlers [1] - ShadowRoot [2] Reflects following spec changes: - whatwg/html#4129 - whatwg/dom#785 Those new spec addition is already implemented in Safari and Gecko[3]. Intent to Ship mail with 3 approvals: [4] [1] https://html.spec.whatwg.org/#globaleventhandlers [2] https://dom.spec.whatwg.org/#interface-shadowroot [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1501983 [4] https://groups.google.com/a/chromium.org/g/blink-dev/c/cagoIboJ6Oo/m/roPoRAEDBAAJ R=fwang@igalia.com, rego@igalia.com Bug: 1006096 Change-Id: I3d0d7eb437aba3e40d24cca9bcf31d1db701f970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3096889 Commit-Queue: SONIA SINGLA <ssingla@igalia.com> Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Manuel Rego <rego@igalia.com> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/main@{#931541} NOKEYCHECK=True GitOrigin-RevId: ec5cf31361e9822ad4c8999dcb34aa1bcca2907a

annevk added 2 commits October 26, 2018 12:09

Add onslotchange

b5a5a1c

Tests: ... Fixes #3487.

let's remove this as HTML doesn't define when this dispatches and it …

acc0390

…doesn't really have a suitable dfn

domenic added topic: shadow Relates to shadow trees (as defined in DOM) needs tests Moving the issue forward requires someone to write tests labels Oct 26, 2018

domenic reviewed Oct 26, 2018

View reviewed changes

Put it back

9873253

domenic removed the needs tests Moving the issue forward requires someone to write tests label Sep 19, 2019

domenic approved these changes Sep 19, 2019

View reviewed changes

domenic merged commit a387c7b into master Sep 20, 2019

domenic deleted the annevk/slotchange branch September 20, 2019 03:55

domenic added a commit to whatwg/dom that referenced this pull request Sep 20, 2019

Define the onslotchange event handler IDL attribute

3fdd74c

This introduces it to ShadowRoot in addition to GlobalEventHandlers, as a counterpart to whatwg/html#4129. Closes whatwg/html#3487.

domenic added a commit to whatwg/dom that referenced this pull request Sep 23, 2019

Define the onslotchange event handler IDL attribute

07a9172

This introduces it to ShadowRoot in addition to GlobalEventHandlers, as a counterpart to whatwg/html#4129. Closes whatwg/html#3487.

annevk pushed a commit to whatwg/dom that referenced this pull request Sep 23, 2019

Define the onslotchange event handler IDL attribute

a6c6d98

This introduces it to ShadowRoot in addition to GlobalEventHandlers, as a counterpart to whatwg/html#4129. Closes whatwg/html#3487.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add onslotchange #4129

Add onslotchange #4129

annevk commented Oct 26, 2018 •

edited by pr-preview bot

Loading

domenic Oct 26, 2018

annevk Oct 26, 2018

domenic Oct 26, 2018

sideshowbarker Oct 26, 2018

domenic commented Sep 19, 2019

annevk commented Sep 20, 2019

annevk commented Sep 20, 2019

domenic commented Sep 20, 2019

domenic commented Sep 20, 2019

Add onslotchange #4129

Add onslotchange #4129

Conversation

annevk commented Oct 26, 2018 • edited by pr-preview bot Loading

domenic Oct 26, 2018

Choose a reason for hiding this comment

annevk Oct 26, 2018

Choose a reason for hiding this comment

domenic Oct 26, 2018

Choose a reason for hiding this comment

sideshowbarker Oct 26, 2018

Choose a reason for hiding this comment

domenic commented Sep 19, 2019

annevk commented Sep 20, 2019

annevk commented Sep 20, 2019

domenic commented Sep 20, 2019

domenic commented Sep 20, 2019

annevk commented Oct 26, 2018 •

edited by pr-preview bot

Loading