-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HostResolveImportedModule asserting _resolved module script_'s instantiation state is "instantiated" does not necessarily hold in cyclic module graph #2596
Labels
Comments
Consider a case where we have: module A -dep-> module B -dep-> moduleA.
|
This seems correct. I think what I should be asserting is simply that its module record is not null. |
domenic
added a commit
that referenced
this issue
Apr 28, 2017
For cyclic module graphs, this assert is overzealous; this adjusts it to assert only what we need. Closes #2596.
domenic
added a commit
that referenced
this issue
May 1, 2017
For cyclic module graphs, this assert is overzealous; this adjusts it to assert only what we need. Closes #2596.
scheib
pushed a commit
to scheib/chromium
that referenced
this issue
May 2, 2017
Before this CL, ScriptModuleResolverImpl::Resolve wrongly assumed that resolved module script's instantiation state is always "instantiated". However, this isn't always the case when instantiating module graph w/ cycles. This CL removes the CHECK. Corresponding spec PR: whatwg/html#2603 BUG=594639, whatwg/html#2596 TEST=external/wpt/html/semantics/scripting-1/the-script-element/module/imports.html shouldn't crash Review-Url: https://codereview.chromium.org/2848213002 Cr-Commit-Position: refs/heads/master@{#468555}
inikulin
pushed a commit
to HTMLParseErrorWG/html
that referenced
this issue
May 9, 2017
For cyclic module graphs, this assert is overzealous; this adjusts it to assert only what we need. Closes whatwg#2596.
inikulin
pushed a commit
to HTMLParseErrorWG/html
that referenced
this issue
May 9, 2017
For cyclic module graphs, this assert is overzealous; this adjusts it to assert only what we need. Closes whatwg#2596.
alice
pushed a commit
to alice/html
that referenced
this issue
Jan 8, 2019
For cyclic module graphs, this assert is overzealous; this adjusts it to assert only what we need. Closes whatwg#2596.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
HostResolveImportedModule Step 6 says:
However, this doesn't always hold when fetching module graph with cycles.
The text was updated successfully, but these errors were encountered: