Skip to content

Commit

Permalink
Fix bad assert in HostResolveImportedModule
Browse files Browse the repository at this point in the history
For cyclic module graphs, this assert is overzealous; this adjusts it
to assert only what we need. Closes whatwg#2596.
  • Loading branch information
domenic authored and Alice Boxhall committed Jan 7, 2019
1 parent 9b6d4ec commit b883c9a
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -88510,9 +88510,7 @@ import "https://example.com/foo/../module2.js";</pre>
data-x="concept-module-script-instantiation-error">instantiation error</span>.</p></li>

<li><p>Assert: <var>resolved module script</var>'s <span
data-x="concept-module-script-instantiation-state">instantiation state</span> is "<code
data-x="">instantiated</code>" (and thus its <span
data-x="concept-module-script-module-record">module record</span> is not null).</p></li>
data-x="concept-module-script-module-record">module record</span> is not null.</p></li>

<li><p>Return <var>resolved module script</var>'s <span
data-x="concept-module-script-module-record">module record</span>.</p></li>
Expand Down

0 comments on commit b883c9a

Please sign in to comment.