Upstream focus navigation behavior for delegatesFocus from W3C spec.
#2013
Comments
|
Can someone assign me to this? |
|
@rakina has started working on this, and it's great. See the auto-generated-by-GitHub links above for details. Does anyone (especially @rakina) have thoughts on whether any of these should be landed independently, or all at once? I am glad @rakina is breaking up the work into small, easily reviewable pieces, but I am personally unsure whether we should land them separately or together. |
|
We probably should land them all at once when either Gecko or WebKit successfully implements |
|
Well, the reason I ask is that #4735 and its tests are pretty independent from delegatesFocus. But I guess implementers might want to just do everything at once. |
|
@domenic : I think Blink, Gecko, and WebKit all more or less implement the interoperable focusing behavior (module browser difference in what is considered as focusable) across shadow boundaries correctly. What's unclear is all the details of integration with |
|
Ah OK, in that case we can probably merge #4735 ahead of the others, assuming that the test results confirm that the results are indeed interoperable. |
|
Well, I guess that has some delegatesFocus stuff in it too, sorry, I misunderstood. Nevermind! |
|
At TPAC a few people notified me that they're interested in following the spec progress for this but weren't sure if they saw everything related to this, so here's a list of relevant links List of related PRs:
Issues:
Not really related to delegatesFocus, but helps clear things up in the focus spec:
|
Fixes #367, i.e. the DOM part of whatwg/html#2013. Further commits in HTML will use this flag.
Part of #2013. Note that the delegates focus flag is not consulted. Tests: web-platform-tests/wpt#17493
This defines an explicit list for the document's "sequential focus navigation order", whose contents are defined to include elements in shadow trees. Previously the contents of the sequential focus navigation order were defined mostly implicitly, in the tabindex section. This also expands the ordering requirements for sequential focus navigation order to account for shadow trees and slotted elements. Finally, this has a minor connection to delegatesFocus, in that it excludes elements that are shadow hosts with delegatesFocus = true from being focusable areas. Part of #2013. Tests: web-platform-tests/wpt#17523
Define "focusable" more concretely, and as part of it, define special types of focusability: click focusable and sequentially focusable. As part of this, remove the "tabindex focus flag" because it can be replaced with "focusable" and "focusable area", and was very confusing. Part of #4607. Helps provide a basis for further work on #2013, but does not directly contribute to any shadow DOM upstreaming. This does not introduce any normative changes, but instead brings into the spec behavior that was previously only in implementations, and makes certain concepts explicit.
|
As far as I've reviewed PRs, things are looking good. I've implemented the new tabIndex behavior in https://bugs.webkit.org/show_bug.cgi?id=199606 and |
This is the last piece of #2013. Incoporating support for delegates-focus shadow roots into the focusing steps impact the behavior of programmatic and click focus. (Sequential focus navigation was handled in d19d963.) Tests: web-platform-tests/wpt#18035
|
Hooray!! Spec updated! @rakina, can you file tracking issues for Gecko and Blink? Ideally you'd include pointers to all the new spec sections, and especially the new web platform tests, but for Blink I'll leave it to you. @rniwa, it sounds like you've got things fully tracked on the WebKit side, but let us know if you'd appreciate any such bug. |
|
Filed bugs in Blink: |
|
Note that the new behavior has been fully implemented in WebKit: Let me know if you find any differences with WebKit's implementation with yours / spec. |
|
Awesome! Thanks for implementing it so quickly. Filed Gecko bugs: |
Part of #2013. Note that the delegates focus flag is not consulted. Tests: web-platform-tests/wpt#17493
This defines an explicit list for the document's "sequential focus navigation order", whose contents are defined to include elements in shadow trees. Previously the contents of the sequential focus navigation order were defined mostly implicitly, in the tabindex section. This also expands the ordering requirements for sequential focus navigation order to account for shadow trees and slotted elements. Finally, this has a minor connection to delegatesFocus, in that it excludes elements that are shadow hosts with delegatesFocus = true from being focusable areas. Part of #2013. Tests: web-platform-tests/wpt#17523
Define "focusable" more concretely, and as part of it, define special types of focusability: click focusable and sequentially focusable. As part of this, remove the "tabindex focus flag" because it can be replaced with "focusable" and "focusable area", and was very confusing. Part of #4607. Helps provide a basis for further work on #2013, but does not directly contribute to any shadow DOM upstreaming. This does not introduce any normative changes, but instead brings into the spec behavior that was previously only in implementations, and makes certain concepts explicit.
This is the last piece of #2013. Incoporating support for delegates-focus shadow roots into the focusing steps impact the behavior of programmatic and click focus. (Sequential focus navigation was handled in d19d963.) Tests: web-platform-tests/wpt#18035
The W3C's Shadow DOM spec modified sequential focus navigation behavior to take into account the state of the
delegatesFocusflag given when creating ShadowRoots. This behavior should be brought into the WHATWG HTML spec.The text was updated successfully, but these errors were encountered: