Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream delegatesFocus property of ShadowRootInit from W3C spec. #367

Closed
bicknellr opened this issue Nov 4, 2016 · 7 comments · Fixed by #768
Closed

Upstream delegatesFocus property of ShadowRootInit from W3C spec. #367

bicknellr opened this issue Nov 4, 2016 · 7 comments · Fixed by #768
Labels
topic: shadow Relates to shadow trees (as defined in DOM)

Comments

@bicknellr
Copy link

The W3C Shadow DOM spec defined a property of ShadowRootInit dictionaries called delegatesFocus. This property still needs to be brought into the WHATWG DOM spec.

@annevk
Copy link
Member

annevk commented Nov 7, 2016

I was wondering if HTML could perhaps define that extension since DOM doesn't really say much about focus. But I suppose that's impossible due to the way dictionaries work.

@TakayoshiKochi
Copy link
Member

I'll handle this with whatwg/html#2013

@TakayoshiKochi
Copy link
Member

Let's track the issue in whatwg/html#2013 and close this.

@TakayoshiKochi
Copy link
Member

Ah, maybe it's worth keeping this issue - we have to tweak ShadowRootInit et al. in dom spec.

@caridy
Copy link

caridy commented Oct 15, 2018

Just a side note: delegatesFocus is a very bad property name for such init value IMHO. Do we have time to revisit it? I have found that this is particularly affecting folks with english as a second language. The most common mistake is forgetting the s from delegates, yes, it is a silly mistake, but nevertheless a mistake. Conjugation, declension and other grammatical rules are not very common in DOM APIs as far as I can remember, I wonder if this can be revisit, e.g. : (activeFocus, focusDelegation or focusTransfer)

This reminds me of some very interesting discussions that we had at TC39 a while ago about language APIs, and how they are perceived by a larger community of developers.

@annevk annevk added the topic: shadow Relates to shadow trees (as defined in DOM) label Oct 16, 2018
@annevk
Copy link
Member

annevk commented Oct 16, 2018

@TakayoshiKochi I think we should probably augment it in HTML via partial if possible.

@annevk
Copy link
Member

annevk commented Oct 16, 2018

@caridy I think only Chrome shipped it, but I believe there was also rough agreement on this API shape already I believe, so it would be kinda bad to ask them to rename at this point.

domenic pushed a commit that referenced this issue Sep 24, 2019
Fixes #367, i.e. the DOM part of
whatwg/html#2013. Further commits in HTML will
use this flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: shadow Relates to shadow trees (as defined in DOM)
Development

Successfully merging a pull request may close this issue.

4 participants