Simplify HeadersInit #418
Merged
Simplify HeadersInit #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Headers has an iterator now through its iterable<> declaration there’s no real need to special case. It might be slightly faster to have it there, but this is not performance-critical code and I’d rather have it be simple.
|
@bzbarsky @wanderview @domenic thoughts? |
|
Does this have any change on behavior visible to script? If not, then I I have no objections. |
|
It does. If you overwrite the iterator of a Headers object that would be invoked instead by the binding layer. |
|
Right, the behavior also changes if people have messed with array iterators (so the inner sequence produces unexpected values). It's probably OK to not worry about those edge cases. |
|
Looks good; tests would probably help. |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 23, 2016
This is a change for whatwg/fetch#418 and also aligns with the recent IDL change to replace OpenEndedDictionary with record.
|
I created web-platform-tests/wpt#4240. It seems we already had many tests for IDL records since everyone implemented that somehow before IDL got them. |
|
Once that lands I'll land this. |
|
Tests landed. Waiting with landing this until a Shepherd issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Headers has an iterator now through its iterable<> declaration
there’s no real need to special case.
It might be slightly faster to have it there, but this is not
performance-critical code and I’d rather have it be simple.