Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect HeadersInit changes #4240

Merged
merged 1 commit into from
Nov 24, 2016
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 23, 2016

This is a change for whatwg/fetch#418 and also
aligns with the recent IDL change to replace OpenEndedDictionary with
record.

This is a change for whatwg/fetch#418 and also
aligns with the recent IDL change to replace OpenEndedDictionary with
record.
@wpt-pr-bot
Copy link
Collaborator

Notifying @jdm and @youennf. (Learn how reviewing works.)

@wpt-stability-bot
Copy link

Firefox

Testing revision 350ba2a386e89f6027f00d56cbc847b89e964d23
Starting 10 test iterations
All results were stable

All results

/fetch/api/headers/headers-basic.html

Subtest Results
OK
Create headers with existing headers with custom iterator FAIL
Create headers with existing headers PASS
Check get method PASS
Create headers from no parameter PASS
Create headers from empty object PASS
Create headers with record PASS
Check forEach method FAIL
Check has method PASS
Check values method FAIL
Check append method PASS
Create headers with 1 should throw PASS
Check set method PASS
Check Symbol.iterator method FAIL
Check entries method FAIL
Create headers from undefined parameter PASS
Check delete method PASS
Create headers with null should throw PASS
Check keys method FAIL
Create headers with sequence PASS

/fetch/api/headers/headers-idl.html

Subtest Results
OK
Headers interface: operation set(ByteString,ByteString) PASS
Headers interface: operation append(ByteString,ByteString) PASS
Headers interface: calling delete(ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: operation delete(ByteString) PASS
Headers interface: operation get(ByteString) PASS
Headers interface object name PASS
Headers interface object length PASS
Headers interface: calling append(ByteString,ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: existence and properties of interface prototype object's "constructor" property PASS
Headers interface: calling get(ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: existence and properties of interface prototype object PASS
Headers interface: calling set(ByteString,ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: new Headers() must inherit property "get" with the proper type (2) PASS
Headers interface: existence and properties of interface object PASS
Headers interface: new Headers() must inherit property "set" with the proper type (4) PASS
Headers interface: calling has(ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: new Headers() must inherit property "append" with the proper type (0) PASS
Headers interface: new Headers() must inherit property "has" with the proper type (3) PASS
Headers must be primary interface of new Headers() PASS
Stringification of new Headers() PASS
Headers interface: operation has(ByteString) PASS
Headers interface: new Headers() must inherit property "delete" with the proper type (1) PASS

@wpt-stability-bot
Copy link

Chrome

Testing revision 350ba2a386e89f6027f00d56cbc847b89e964d23
Starting 10 test iterations
All results were stable

All results

/fetch/api/headers/headers-basic.html

Subtest Results
OK
Create headers with existing headers with custom iterator FAIL
Create headers with existing headers PASS
Check get method PASS
Create headers from no parameter PASS
Create headers from empty object PASS
Create headers with record PASS
Check forEach method FAIL
Check has method PASS
Check values method FAIL
Check append method PASS
Create headers with 1 should throw PASS
Check set method PASS
Check Symbol.iterator method FAIL
Check entries method FAIL
Create headers from undefined parameter FAIL
Check delete method PASS
Create headers with null should throw PASS
Check keys method FAIL
Create headers with sequence PASS

/fetch/api/headers/headers-idl.html

Subtest Results
OK
Headers interface: operation set(ByteString,ByteString) PASS
Headers interface: operation append(ByteString,ByteString) PASS
Headers interface: calling delete(ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: operation delete(ByteString) PASS
Headers interface: operation get(ByteString) PASS
Headers interface object name PASS
Headers interface object length PASS
Headers interface: calling append(ByteString,ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: existence and properties of interface prototype object's "constructor" property PASS
Headers interface: calling get(ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: existence and properties of interface prototype object FAIL
Headers interface: calling set(ByteString,ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: new Headers() must inherit property "get" with the proper type (2) PASS
Headers interface: existence and properties of interface object PASS
Headers interface: new Headers() must inherit property "set" with the proper type (4) PASS
Headers interface: calling has(ByteString) on new Headers() with too few arguments must throw TypeError PASS
Headers interface: new Headers() must inherit property "append" with the proper type (0) PASS
Headers interface: new Headers() must inherit property "has" with the proper type (3) PASS
Headers must be primary interface of new Headers() PASS
Stringification of new Headers() PASS
Headers interface: operation has(ByteString) PASS
Headers interface: new Headers() must inherit property "delete" with the proper type (1) PASS

@youennf youennf merged commit f7cc6a4 into master Nov 24, 2016
@annevk annevk deleted the annevk/fetch-headersinit-idl-changes branch November 24, 2016 09:20
annevk added a commit to whatwg/fetch that referenced this pull request Nov 30, 2016
Since Headers has an iterator now through its iterable<> declaration
there’s no real need to special case.

It might be slightly faster to have it there, but this is not
performance-critical code and I’d rather have it be simple.

Tests: web-platform-tests/wpt#4240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants