-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect HeadersInit changes #4240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a change for whatwg/fetch#418 and also aligns with the recent IDL change to replace OpenEndedDictionary with record.
Notifying @jdm and @youennf. (Learn how reviewing works.) |
FirefoxTesting revision 350ba2a386e89f6027f00d56cbc847b89e964d23 All results/fetch/api/headers/headers-basic.html
/fetch/api/headers/headers-idl.html
|
ChromeTesting revision 350ba2a386e89f6027f00d56cbc847b89e964d23 All results/fetch/api/headers/headers-basic.html
/fetch/api/headers/headers-idl.html
|
youennf
approved these changes
Nov 24, 2016
annevk
added a commit
to whatwg/fetch
that referenced
this pull request
Nov 30, 2016
Since Headers has an iterator now through its iterable<> declaration there’s no real need to special case. It might be slightly faster to have it there, but this is not performance-critical code and I’d rather have it be simple. Tests: web-platform-tests/wpt#4240.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change for whatwg/fetch#418 and also
aligns with the recent IDL change to replace OpenEndedDictionary with
record.