Add StartupWMClass on Linux desktop file #1138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
mathiasvr
approved these changes
Sep 25, 2018
|
Any news? |
|
LGTM 👍 |
Yes it is already in my PR, so we can close this one 😉 BTW, thank you @bilelmoussaoui for this PR 👍 |
|
Cool, closing this. Thanks @bilelmoussaoui! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StartupWMClass is used to identify the opened applications under Linux with their desktop files, which means using the right icon and so on... more information can be found here https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
The value assigned on StartupWMClass can be easily found using
xprop WM_CLASSand click other application you would like to get the WM_CLASS.What does this affect? Nothing at all, The only difference is that if an icon theme includes an icon for WebTorrent it will be used instead of using the default one. Also, the default one will look blurry on some Desktop environments. And the user won't be able to get to use the actions defined in the desktop file while running the application if it's not correctly identified. This is mostly needed for non-native applications
Without a WM_CLASS:
With a WM_CLASS:
