-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebTorrent Desktop fix #382
Conversation
I have been using WebTorrent Desktop for a while, and i have never notice a tray icon :o |
How did you enable that? |
i'm use your tool and seen your PR webtorrent/webtorrent-desktop#1138 |
Ah that wasn't a tray icon :o i'm using dash to panel, and those are apps icons |
Yes, yes StartupWMClassFixer fix that ) |
But it's isn't a Tray icon so :p this PR doesn't fix any tray icon at all |
No, it's tray icon, because on desktop file use another icon:
Icon=webtorrent-desktop |
Hardcode-tray + StartupWMClassFixer = fixed all. Why not?! |
Ah you're right! except this tray icon doesn't show up at all.. I just checked the source code and it's a tray icon. |
ok |
It should work on Ubuntu https://github.com/webtorrent/webtorrent-desktop/blob/c764bf48841beb63c8820b3aaf568d3f0852ac75/src/main/tray.js#L109 |
It won't work on arch but thanks for the PR 👍 |
But libappindicator available from aur ... and not worked? |
@varlesh Read that comment on the code https://github.com/webtorrent/webtorrent-desktop/blob/c764bf48841beb63c8820b3aaf568d3f0852ac75/src/main/tray.js#L54 |
It's electron app, but asar unpacked (for icons only). For right work need use with
StartupWMClass=WebTorrent
, because desktop icon show as tray icon without WMClass...