Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent Desktop fix #382

Merged
merged 4 commits into from
Jun 15, 2017
Merged

WebTorrent Desktop fix #382

merged 4 commits into from
Jun 15, 2017

Conversation

varlesh
Copy link
Collaborator

@varlesh varlesh commented Jun 14, 2017

It's electron app, but asar unpacked (for icons only). For right work need use with StartupWMClass=WebTorrent, because desktop icon show as tray icon without WMClass...

@bilelmoussaoui
Copy link
Owner

I have been using WebTorrent Desktop for a while, and i have never notice a tray icon :o

@bilelmoussaoui
Copy link
Owner

How did you enable that?

@varlesh
Copy link
Collaborator Author

varlesh commented Jun 14, 2017

i'm use your tool and seen your PR webtorrent/webtorrent-desktop#1138

@bilelmoussaoui
Copy link
Owner

Ah that wasn't a tray icon :o i'm using dash to panel, and those are apps icons
WebTorrent is already supported by StartupWMClassFixer btw https://github.com/bil-elmoussaoui/StartupWMClassFixer/blob/master/database.csv#L68

@varlesh
Copy link
Collaborator Author

varlesh commented Jun 14, 2017

Yes, yes StartupWMClassFixer fix that )

@bilelmoussaoui
Copy link
Owner

But it's isn't a Tray icon so :p this PR doesn't fix any tray icon at all

@varlesh
Copy link
Collaborator Author

varlesh commented Jun 14, 2017

No, it's tray icon, because on desktop file use another icon:

Name=WebTorrent
Version=1.0
GenericName=BitTorrent Client
X-GNOME-FullName=WebTorrent
Comment=Download and share files over BitTorrent
Encoding=UTF-8
Type=Application
Icon=webtorrent-desktop
Terminal=false

Icon=webtorrent-desktop

@varlesh
Copy link
Collaborator Author

varlesh commented Jun 14, 2017

Hardcode-tray + StartupWMClassFixer = fixed all. Why not?!

@bilelmoussaoui
Copy link
Owner

Ah you're right! except this tray icon doesn't show up at all.. I just checked the source code and it's a tray icon.
Can you please add this location too ? /usr/share/webtorrent-desktop/
On archlinux, the files are not installed on /opt

@varlesh
Copy link
Collaborator Author

varlesh commented Jun 14, 2017

ok

@bilelmoussaoui
Copy link
Owner

It should work on Ubuntu https://github.com/webtorrent/webtorrent-desktop/blob/c764bf48841beb63c8820b3aaf568d3f0852ac75/src/main/tray.js#L109
As you can see on that file, they force to check that you're using Ubuntu or Debian & check if you have the libappindicator installed...

@varlesh
Copy link
Collaborator Author

varlesh commented Jun 15, 2017

On Ubuntu with Gnome all worked fine, but on Arch i don't know...
image

@bilelmoussaoui
Copy link
Owner

It won't work on arch but thanks for the PR 👍

@bilelmoussaoui bilelmoussaoui merged commit fc8ec20 into bilelmoussaoui:master Jun 15, 2017
@varlesh
Copy link
Collaborator Author

varlesh commented Jun 15, 2017

But libappindicator available from aur ... and not worked?

@bilelmoussaoui
Copy link
Owner

bilelmoussaoui commented Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants