ast(cli): Recursively parse AST #341

evenstensberg · 2018-03-12T12:24:03Z

What kind of change does this PR introduce?

Refactoring
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Refactors AST parsing, cutting a lot of dead code and simplifies our repository. It removes alot of tech burden and potential bug reports.

It's fun

Does this PR introduce a breaking change?
Probably a major

Logic still intact
Other information
Good stuff

ematipico · 2018-03-14T13:16:09Z

lib/generate-plugin/index.js

@@ -1,5 +1,6 @@
 const yeoman = require("yeoman-environment");
-const PluginGenerator = require("../generators/plugin-generator").PluginGenerator;
+const PluginGenerator = require("../generators/plugin-generator")


This can be destructured :)

const { PluginGenerator } = require("../generators/plugin-generator")

Im not done

yeah and in the meantime we give feedback while you develop :)

Gotcha, just don't want you to do extra work 🙌🤙

bitpshr · 2018-04-25T17:57:58Z

@ev1stensberg nice work so far, let us know when it’s ready to review.

evenstensberg · 2018-04-27T18:32:53Z

.yo-rc.json

@@ -0,0 +1,23 @@
+{


Ups, forgot this!

evenstensberg · 2018-04-27T18:42:23Z

🤔🤔🤔🤔🤔🤔🤔🤔🤔

webpack-bot · 2018-04-28T18:10:35Z

@ev1stensberg Please review the following output log for errors:

> webpack-cli@2.0.15 travis:integration /home/travis/build/webpack/webpack-cli
> nyc jest && npm run reportCoverage

PASS lib/utils/resolve-packages.test.js (14.433s)
PASS lib/utils/is-local-path.test.js (17.169s)
PASS lib/utils/npm-exists.test.js (21.98s)
PASS lib/utils/package-manager.test.js (25.002s)
PASS lib/utils/validate-identifier.test.js (25.216s)
PASS lib/generators/loader-generator.test.js (26.632s)
PASS lib/migrate/resolve/resolve.test.js (26.576s)
PASS lib/migrate/extractTextPlugin/extractTextPlugin.test.js (30.048s)
PASS lib/migrate/noEmitOnErrorsPlugin/noEmitOnErrorsPlugin.test.js (31.163s)
PASS lib/migrate/namedModulesPlugin/namedModulesPlugin.test.js (31.231s)
PASS lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.test.js (31.746s)
  ● Console

    console.log lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.js:37
      
      Please remove deprecated plugins manually. 
      See https://webpack.js.org/guides/migrating/ for more information.
    console.log lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.js:37
      
      Please remove deprecated plugins manually. 
      See https://webpack.js.org/guides/migrating/ for more information.
    console.log lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.js:37
      
      Please remove deprecated plugins manually. 
      See https://webpack.js.org/guides/migrating/ for more information.

PASS lib/migrate/bannerPlugin/bannerPlugin.test.js (32.34s)
PASS lib/ast/ast.test.js (32.431s)
PASS lib/utils/ast-utils.test.js (34.082s)
PASS lib/migrate/moduleConcatenationPlugin/moduleConcatenationPlugin.test.js (32.121s)
PASS lib/migrate/loaderOptionsPlugin/loaderOptionsPlugin.test.js (32.318s)
PASS lib/migrate/uglifyJsPlugin/uglifyJsPlugin.test.js (34.354s)
PASS lib/migrate/removeJsonLoader/removeJsonLoader.test.js (32.819s)
PASS lib/migrate/outputPath/outputPath.test.js (33.519s)
PASS lib/migrate/loaders/loaders.test.js (33.733s)
PASS lib/migrate/index.test.js (34.956s)
PASS lib/utils/npm-packages-exists.test.js (36.346s)
PASS test/BinTestCases.test.js (219.447s)

=============================== Coverage summary ===============================
Statements   : 84.81% ( 893/1053 )
Branches     : 76.22% ( 282/370 )
Functions    : 83.26% ( 199/239 )
Lines        : 85.58% ( 878/1026 )
===

See complete report here.

sendilkumarn

Good work 👍

evenstensberg · 2018-04-30T09:00:18Z

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

* fix(loader,plugin): fix generators path bug * cli(refactor): improve folder structure (#371) * cli(refactor): improve folder structure * chore(linting): fix linter errors * cli(filepath): use local import instead * cli(migrate): refactor error handling * chore(review): fix review comments * chore(review): fix review comments * chore(review): fix review comments * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(init): mode support to config (#364) * cli(init): mode support to config * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * cli(init): webpack4 ready (#356) * cli(init): webpack4 ready * cli(init): remove unused variable, still @next on etwp * cli(init): Allow to use default entry in `init` * cli(init): Fix typo in comment * cli(init): Optimization transform and tests * cli(init): Fix non-optimized option for splitChunks * cli(init): Add cachingGroup per entry, don't show name in prod * cli(init): Add cachingGroup's defaults, fix entry * cli(init): Add a link to where the defaults live * cli(init): Remove default caching group definition from example * Add NoEmitOnErrorsPlugin transformation (#399) * ast(migrate): handle no emit on error * ast(migrate): handle module concatenation and named modules * ast(migrate): handle module concatenation and named modules * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * cli(entry): quotes sanitization (#337) * chore: minor doc fixes * cli(entry): quotes sanitization * tests(entry): add test case for double quotes * tests(entry): update snapshots * misc(utils): entry - variable parity * misc(prop-types): sort * cli(entry): multiple entries quotes sanitization * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * cli(migration): update UglifyJS transformation (#416) * cli(migration): Update UglifyJS migration file to fit webpack4 configuration * cli(migration): Add cases where require variable does not need to exist * cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin * cli(tests): Update test snapshots after updating transformation * cli(fix): fix expressionContent being null * cli(refactor): remove plugins array if empty Created function on ast-utils so every other transformation can use this. * tests: add tests for new ast-utils method * fix: fix test names and jsdoc * fix: update maxSize for utils folder * ast(cli): Recursively parse AST (#341) * ast(refactor): wip refactor * ast(refactor): wip refactor * ast(init): refactor * test(refactor): refactor test suite * tests(define): swap args * ast(parsing): refactor stuff * ast(init): refactor * ast(init): refactor tests * chore(tests): remove some unneeded tests * chore(pkg): update package.json * chore(project): clear up project structure * chore(cli): remove unneded files * chore(git): add gitignore to yeoman file * chore(deps): update pkg.json * tests(snapshots): update snapshots * tests(jest): use empty module for snapshots * tests(snap): only test one prop * chore(publishing): add semantic-release (#415) * chore(release): [WIP] add semantic-release * test(ci): wip * test(ci): add node versions * test(ci): remove extra test * tests(ci): revise * tests(ci): only push to npm on master * tests(ci): use matrix on jobs * tests(ci): revise * tests(ci): update * tests(ci): test * tests(ci): test * tests(ci): p * tests(ci): update travis.yml * chore(release): revise travis * misc(yeoman): update yeoman * chore(travis): revise travis * misc(travis): revise travis.yml * chore(travis): remove redundant code * chore(pkg): add keywords * 2.1.1 * 2.1.2 * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(lerna): refactor * chore(lerna): refactor * chore(refactor): refactor stuff * chore(package): update pkg.lock * chore(templates): Update issue templates (#432) Adds fancy templates * ast(init): add topScope prop * ast(merge): re-add merge prop * cli(lerna): refactor * chore(lerna): refactor * chore(lerna): update * chore(lint): revise * chore(refactor): refactor * chore(tests): use lerna for tests * chore(travis): don't cache me outside * chore(pkg): remove prefer global * chore(release): v.2.1.3 * chore(package.lock): update pkg.lock * fix(loader,plugin): fix generators path bug * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * misc(yeoman): update yeoman * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(templates): Update issue templates (#432) Adds fancy templates * cli(lerna): refactor * chore(lerna): refactor * chore(pkg): remove prefer global * chore(travis): Add encrypted private ssh key * fix(pkg): test auto setup * cli(init): revise installation steps (#441) * cli(init): revise installation steps * chore(formatting): format code * cli(tests): refactor tests * chore(travis): run lockfile cmds on tests (#444) * Update dependencies to enable Greenkeeper 🌴 (#443) chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴 * chore(docs): update readme * chore(travis): add Node.js 10 (#425) * chore(travis): move npm ci to install task (#424) * chore(travis): move npm ci to install task * chore: trigger new build * chore: upgrade Node.js for Appveyor to 8 * chore: remove redundanct npm install command

* chore(monorepo): move to lerna * chore(monorepo): use commands as normal instead of package * fix(revert): packagejson * chore(monorepo): prune files and update eslint rules * chore(monorepo): fix the no-missing-require error * chore(monorepo): fix typo * chore(monorepo): fix typo * chore(monorepo): prune package json * chore(monorepo): merge package lock json * chore(monorepo): updated package.json * chore(monorepo): fix plugin package.json * chore(cli): move to lerna and scoped packages (#434) * fix(loader,plugin): fix generators path bug * cli(refactor): improve folder structure (#371) * cli(refactor): improve folder structure * chore(linting): fix linter errors * cli(filepath): use local import instead * cli(migrate): refactor error handling * chore(review): fix review comments * chore(review): fix review comments * chore(review): fix review comments * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(init): mode support to config (#364) * cli(init): mode support to config * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * cli(init): webpack4 ready (#356) * cli(init): webpack4 ready * cli(init): remove unused variable, still @next on etwp * cli(init): Allow to use default entry in `init` * cli(init): Fix typo in comment * cli(init): Optimization transform and tests * cli(init): Fix non-optimized option for splitChunks * cli(init): Add cachingGroup per entry, don't show name in prod * cli(init): Add cachingGroup's defaults, fix entry * cli(init): Add a link to where the defaults live * cli(init): Remove default caching group definition from example * Add NoEmitOnErrorsPlugin transformation (#399) * ast(migrate): handle no emit on error * ast(migrate): handle module concatenation and named modules * ast(migrate): handle module concatenation and named modules * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * cli(entry): quotes sanitization (#337) * chore: minor doc fixes * cli(entry): quotes sanitization * tests(entry): add test case for double quotes * tests(entry): update snapshots * misc(utils): entry - variable parity * misc(prop-types): sort * cli(entry): multiple entries quotes sanitization * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * cli(migration): update UglifyJS transformation (#416) * cli(migration): Update UglifyJS migration file to fit webpack4 configuration * cli(migration): Add cases where require variable does not need to exist * cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin * cli(tests): Update test snapshots after updating transformation * cli(fix): fix expressionContent being null * cli(refactor): remove plugins array if empty Created function on ast-utils so every other transformation can use this. * tests: add tests for new ast-utils method * fix: fix test names and jsdoc * fix: update maxSize for utils folder * ast(cli): Recursively parse AST (#341) * ast(refactor): wip refactor * ast(refactor): wip refactor * ast(init): refactor * test(refactor): refactor test suite * tests(define): swap args * ast(parsing): refactor stuff * ast(init): refactor * ast(init): refactor tests * chore(tests): remove some unneeded tests * chore(pkg): update package.json * chore(project): clear up project structure * chore(cli): remove unneded files * chore(git): add gitignore to yeoman file * chore(deps): update pkg.json * tests(snapshots): update snapshots * tests(jest): use empty module for snapshots * tests(snap): only test one prop * chore(publishing): add semantic-release (#415) * chore(release): [WIP] add semantic-release * test(ci): wip * test(ci): add node versions * test(ci): remove extra test * tests(ci): revise * tests(ci): only push to npm on master * tests(ci): use matrix on jobs * tests(ci): revise * tests(ci): update * tests(ci): test * tests(ci): test * tests(ci): p * tests(ci): update travis.yml * chore(release): revise travis * misc(yeoman): update yeoman * chore(travis): revise travis * misc(travis): revise travis.yml * chore(travis): remove redundant code * chore(pkg): add keywords * 2.1.1 * 2.1.2 * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(lerna): refactor * chore(lerna): refactor * chore(refactor): refactor stuff * chore(package): update pkg.lock * chore(templates): Update issue templates (#432) Adds fancy templates * ast(init): add topScope prop * ast(merge): re-add merge prop * cli(lerna): refactor * chore(lerna): refactor * chore(lerna): update * chore(lint): revise * chore(refactor): refactor * chore(tests): use lerna for tests * chore(travis): don't cache me outside * chore(pkg): remove prefer global * chore(release): v.2.1.3 * chore(package.lock): update pkg.lock * fix(loader,plugin): fix generators path bug * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * misc(yeoman): update yeoman * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(templates): Update issue templates (#432) Adds fancy templates * cli(lerna): refactor * chore(lerna): refactor * chore(pkg): remove prefer global * chore(travis): Add encrypted private ssh key * fix(pkg): test auto setup * cli(init): revise installation steps (#441) * cli(init): revise installation steps * chore(formatting): format code * cli(tests): refactor tests * chore(travis): run lockfile cmds on tests (#444) * Update dependencies to enable Greenkeeper 🌴 (#443) chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴 * chore(docs): update readme * chore(travis): add Node.js 10 (#425) * chore(travis): move npm ci to install task (#424) * chore(travis): move npm ci to install task * chore: trigger new build * chore: upgrade Node.js for Appveyor to 8 * chore: remove redundanct npm install command * chore(linting): resolve linter errors * chore(linting): fix linting errors * chore(linting): resolve linting * chore(linting): resolve linting * chore(scaffold): move addons to scaffold * chore(scaffold): fix linting errors * cli(prompt): initial comment for prompt file * cli(prompt): wip * fix(monorepo): fix lint errors * fix(monorepo): fix cross spawn versions * fix(monorepo): update lock files * fix(monorepo): fix versions in pacakges * chore(rebase): refactor stuff * cli(pkgs): re-add entries * chore(v): revise pkg * v0.0.1 * chore(v): revise some deps * v0.0.2 * v0.0.3 * chore(v): back to v1 * v0.0.2 * v0.0.3 * v0.0.4 * chore(deps): update deps * chore(prompt): revise prompt cmd * v0.0.5 * cli(path): resolve better * v0.0.6 * chore(v.6): update init * chore(pkg): v.6 on next * chore(monorepo): add bootstrap to run chore(monorepo): add bootstrap to ci * chore(monorepo): fix appveyor build * chore(monorepo): fix appveyor build * chore(monorepo): add eslint-plugin-prettier * chore(monorepo): fix appveyor build chore(monorepo): fix appveyor build chore(monorepo): add eslint-plugin-prettier chore(monorepo): use nohoist * chore(monorepo): fix versions and use clean bootstrap * chore(monorepo): add rimraf globally chore(monorepo): revert back * chore(monorepo): fix windows build * cli(color): don't use color on non-tty (#452) * Added yarn lock file to gitignore (#455) * chore(next): dev version bump * chore(monorepo): fix windows build * cli(symlinks): Fix paths (#453) * cli(symlinks): fix symlinks * chore(linting): resolve linting errors * chore(rebase): remove old file * cli(init): Better defaults (#451) * cli(init): set default generator name * cli(init): better defaults * chore(rebase): remove old commit * cli(init): fix broken ast and merge scaffolds * chore(docs): better defaults * chore(lint): fix linting errors * chore(deps): remove path from dep installation * chore(resolve): resolve conflicts * fix(vulnerabilities): vulnerabilities patch for v3 (#460) * chore(dependencies): fix vulnerabilities * misc(scripts): update clean:all script * chore(dependencies): fix vulnerabilities * tests(parser): fix recursive-tests signature (#470) * chore(deps): add lerna * tests(coverage): fix coverage (#473) * test(coverage): fix coverage * test(binTestCases): run bintestcases on upper-repo * tests(travis): add node 10 * tests(cov): use regular nyc on tests * chore(lockfile): update pkglock * chore(semantic): configure plugins (#475) * fix(cli): show help flag when defaults fail (#466) * fixed test cases * remove unwanted console * fix(254) - addressed PR comments * fix(254) - added requested changes at right place * fix(254) - exit after error exit webpack if defaults are not found fix test cases for no options * fix: require chalk * refactor - addressed PR comments * refactor - addressed PR comments * refactor : remove unwanted keywords * chore(review): format * tests(no-options): refactor tests * ast(parser): add (#456) * ast(parser): add, update, remove - literal node support * ast(parser): add command * ast(util): update property, early exit * tests(add): resursive add ast * tests(add): update recursive parser snaps * misc(conflicts): resolve conflicts * tests(parser): update tests, inputs * chore(review): fix some things * ast(utils): add ast-path safe traverse and type support * ast(utils): merge update property with add property * tests(ast): add tests for safe traversals * misc(fixes): review comments * tests(ast): add tests for addProperty * misc(fixes): review comments * misc(fixes): review comments * misc(fixes): review comments * cli(add): re-add add command

evenstensberg added 2 commits March 12, 2018 13:21

ast(refactor): wip refactor

e82c7eb

ast(refactor): wip refactor

c388042

webpack-bot added PR: unreviewed PR: CI-not-ok labels Mar 12, 2018

evenstensberg added 2 commits March 14, 2018 11:14

ast(init): refactor

a573ff8

test(refactor): refactor test suite

15edbb2

webpack deleted a comment from webpack-bot Mar 14, 2018

tests(define): swap args

c2ef49f

webpack deleted a comment from webpack-bot Mar 14, 2018

ematipico reviewed Mar 14, 2018

View reviewed changes

webpack-bot added PR: conflict and removed PR: CI-not-ok labels Apr 3, 2018

ast(parsing): refactor stuff

f961419

evenstensberg added 3 commits April 27, 2018 19:18

ast(init): refactor

5b4b623

ast(init): refactor tests

b8f4979

chore(tests): remove some unneeded tests

af8393d

webpack deleted a comment from webpack-bot Apr 27, 2018

evenstensberg added 4 commits April 27, 2018 19:43

chore(pkg): update package.json

c64ed99

chore(project): clear up project structure

ea02412

chore(cli): remove unneded files

6ff4248

chore(git): merge master branch

9892028

webpack-bot removed the PR: conflict label Apr 27, 2018

evenstensberg requested review from ematipico, fokusferit, dhruvdutt, EugeneHlushko and sendilkumarn April 27, 2018 18:32

evenstensberg commented Apr 27, 2018

View reviewed changes

.yo-rc.json Outdated

@@ -0,0 +1,23 @@

{

Copy link

Member Author

evenstensberg Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, forgot this!

chore(git): add gitignore to yeoman file

2b1f1d5

evenstensberg changed the title ~~[WIP] Refactor ast~~ ast(cli): Recursively parse AST Apr 27, 2018

webpack-bot added the PR: CI-not-ok label Apr 27, 2018

chore(deps): update pkg.json

0ce8138

webpack deleted a comment from webpack-bot Apr 28, 2018

evenstensberg added 3 commits April 28, 2018 14:48

tests(snapshots): update snapshots

3d7fba8

tests(jest): use empty module for snapshots

9e7e2b5

tests(snap): only test one prop

ef9327a

webpack deleted a comment from webpack-bot Apr 28, 2018

sendilkumarn reviewed Apr 28, 2018

View reviewed changes

ematipico approved these changes Apr 29, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: unreviewed labels Apr 29, 2018

evenstensberg merged commit 77eaf24 into master Apr 30, 2018

evenstensberg deleted the refactor-ast branch April 30, 2018 05:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ast(cli): Recursively parse AST #341

ast(cli): Recursively parse AST #341

evenstensberg commented Mar 12, 2018 •

edited

Loading

ematipico Mar 14, 2018

evenstensberg Mar 14, 2018

ematipico Mar 14, 2018

evenstensberg Mar 14, 2018

bitpshr commented Apr 25, 2018

evenstensberg Apr 27, 2018

evenstensberg commented Apr 27, 2018

webpack-bot commented Apr 28, 2018

sendilkumarn left a comment

evenstensberg commented Apr 30, 2018

ast(cli): Recursively parse AST #341

ast(cli): Recursively parse AST #341

Conversation

evenstensberg commented Mar 12, 2018 • edited Loading

ematipico Mar 14, 2018

Choose a reason for hiding this comment

evenstensberg Mar 14, 2018

Choose a reason for hiding this comment

ematipico Mar 14, 2018

Choose a reason for hiding this comment

evenstensberg Mar 14, 2018

Choose a reason for hiding this comment

bitpshr commented Apr 25, 2018

evenstensberg Apr 27, 2018

Choose a reason for hiding this comment

evenstensberg commented Apr 27, 2018

🤔🤔🤔🤔🤔🤔🤔🤔🤔

webpack-bot commented Apr 28, 2018

sendilkumarn left a comment

Choose a reason for hiding this comment

evenstensberg commented Apr 30, 2018

evenstensberg commented Mar 12, 2018 •

edited

Loading