This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
Add WorkerType functionality (replaces #178) #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zeripath
force-pushed
the
shared-worker
branch
2 times, most recently
from
c9b6858
to
4500188
Compare
This is a slightly adjusted version of webpack-contrib#178 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 66.31% 59.29% -7.03%
==========================================
Files 6 6
Lines 95 113 +18
Branches 28 36 +8
==========================================
+ Hits 63 67 +4
- Misses 28 41 +13
- Partials 4 5 +1
Continue to review full report at Codecov.
|
alexander-akait
suggested changes
Jun 29, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
changed the title
alexander-akait
approved these changes
Jun 30, 2020
This was referenced Jun 30, 2020
TheLD6978
pushed a commit
to TheLD6978/worker-loader
that referenced
this pull request
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Allows worker-loader to create other worker types by adding an option
workerTypewhich defaults toWorkerbut could be used to createServiceWorkerorSharedWorker.Breaking Changes
None
Additional Info
This is an updated version of #178
Signed-off-by: Andrew Thornton art27@cantab.net