This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
refactor: webpack SharedWorker #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
A
suggested changes
Jan 31, 2019
src/workers/InlineWorker.js
Outdated
| @@ -24,15 +32,15 @@ module.exports = function (content, url) { | |||
| blob = new Blob([content]); | |||
| } | |||
|
|
|||
| return new Worker(URL.createObjectURL(blob)); | |||
| return new createWorker(URL.createObjectURL(blob), options.isSharedWorker); | |||
There was a problem hiding this comment.
Confusing to see both new and CreateWorker(), that not looks like a constructor
There was a problem hiding this comment.
sorry， new and CreateWorker() resolve
|
is there any progress on shared workers? it would be cool if i use another tab re-using the same worker, would be much faster |
developit
suggested changes
Mar 9, 2020
| module.exports = function (content, url) { | ||
| function CreateWorker(url, isSharedWorker) { | ||
| if (isSharedWorker) { | ||
| return new isSharedWorker(url); |
There was a problem hiding this comment.
Suggested change
| return new isSharedWorker(url); | |
| return new SharedWorker(url); |
zeripath
added a commit
to zeripath/worker-loader
that referenced
this pull request
Jun 27, 2020
This is a slightly adjusted version of webpack-contrib#178 Signed-off-by: Andrew Thornton <art27@cantab.net>
6 tasks
zeripath
added a commit
to zeripath/worker-loader
that referenced
this pull request
Jun 27, 2020
This is a slightly adjusted version of webpack-contrib#178 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/worker-loader
that referenced
this pull request
Jun 27, 2020
This is a slightly adjusted version of webpack-contrib#178 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/worker-loader
that referenced
this pull request
Jun 27, 2020
This is a slightly adjusted version of webpack-contrib#178 Signed-off-by: Andrew Thornton <art27@cantab.net>
alexander-akait
pushed a commit
that referenced
this pull request
Jun 30, 2020
|
Done here #247 |
TheLD6978
pushed a commit
to TheLD6978/worker-loader
that referenced
this pull request
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
no
Breaking Changes
no
Additional Info
add isLoaderWorker options