Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): add webpack >= v4.0.0 (peerDependencies) #541

Merged
merged 1 commit into from
Mar 1, 2018
Merged

fix(package): add webpack >= v4.0.0 (peerDependencies) #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,20 +54,15 @@
},
"peerDependencies": {
"node-sass": "^4.0.0",
"webpack": "^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0"
"webpack": "^2.0.0 || ^3.0.0 || ^4.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also breaking change 😞 Let's add just ^4.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a breaking change ? Polluting this prop with alpha, beta, rc versions is really not a good idea and most folks should have updated to the latest webpack@3.0.0 by now I assumed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky someone can use rc.0 and it can break build, but i agree with you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it breaks :)

},
"keywords": [
"sass",
"libsass",
"webpack",
"loader"
],
"repository": {
"type": "git",
"url": "git://github.com/webpack-contrib/sass-loader.git"
},
"bugs": {
"url": "https://github.com/webpack-contrib/sass-loader/issues"
},
"repository": "https://github.com/webpack-contrib/sass-loader.git",
"bugs": "https://github.com/webpack-contrib/sass-loader/issues",
"homepage": "https://github.com/webpack-contrib/sass-loader"
}