Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): add webpack >= v4.0.0 (peerDependencies) #541

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

michael-ciniawsky
Copy link
Member

No description provided.

@michael-ciniawsky michael-ciniawsky added this to the 6.0.7 milestone Feb 28, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix(package) add webpack >= v4.0.0 (peerDependencies) fix(package): add webpack >= v4.0.0 (peerDependencies) Feb 28, 2018
package.json Outdated
@@ -50,24 +50,19 @@
"webpack-merge": "^4.0.0"
},
"engines": {
"node": ">= 4.3 < 5.0.0 || >= 5.10"
"node": ">= 4.8 < 5.0.0 || >= 5.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change 😞

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a breaking change ? But I can revert it in this PR doesn't matter...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky let's do it in next major 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

},
"peerDependencies": {
"node-sass": "^4.0.0",
"webpack": "^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0"
"webpack": "^2.0.0 || ^3.0.0 || ^4.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also breaking change 😞 Let's add just ^4.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a breaking change ? Polluting this prop with alpha, beta, rc versions is really not a good idea and most folks should have updated to the latest webpack@3.0.0 by now I assumed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky someone can use rc.0 and it can break build, but i agree with you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it breaks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants