Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CI to use node 12 #2576

Closed
antross opened this issue Jun 10, 2019 · 1 comment · Fixed by #2795
Closed

Upgrade CI to use node 12 #2576

antross opened this issue Jun 10, 2019 · 1 comment · Fixed by #2795
Assignees
@antross
Labels
area:infrastructure
Milestone
1908-2

Comments

@antross
Copy link
Member

antross commented Jun 10, 2019

Depends on having pre-built binaries for canvas on all of our target platforms (linux, macOS, and Windows).

Currently no pre-built canvas binaries are available for node 12 on Windows so we've reverted to using node 11 in CI until the issue is resolved: node-gfx/node-canvas-prebuilt#78
@antross antross added this to the 1906-2 milestone Jun 10, 2019
@antross antross self-assigned this Jun 10, 2019
@antross antross modified the milestones: 1906-2, 1907-1 Jun 21, 2019
@antross antross removed their assignment Jun 21, 2019
@antross antross removed this from the 1907-1 milestone Jul 8, 2019
@antross antross removed the blocked label Aug 5, 2019
@antross
Copy link
Member Author

antross commented Aug 5, 2019

Pre-built binaries for canvas were just published so this is no longer blocked.

@antross antross added this to the 1908-2 milestone Aug 5, 2019
@antross antross self-assigned this Aug 6, 2019
antross added a commit to antross/hint that referenced this issue Aug 6, 2019
@antross
Build: Re-enable using node 12.x instead of 11.x in CI
da3e974 
This reverts commit 3ab9b9a.

- - - - - - - - - -

Fix webhintio#2576
@antross antross mentioned this issue Aug 6, 2019
Merged
4 tasks
antross added a commit that referenced this issue Aug 7, 2019
@antross
Build: Re-enable using node 12.x instead of 11.x in CI
52fa82c 
This reverts commit 3ab9b9a.

- - - - - - - - - -

Fix #2576
Close #2795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antross antross

Labels
area:infrastructure
Projects
None yet
Milestone
1908-2
Development

Successfully merging a pull request may close this issue.

Build: Re-enable using node 12.x instead of 11.x in CI antross/hint
1 participant
@antross