Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt for node_v72 #78

Closed
BenoitClaveau opened this issue May 6, 2019 · 3 comments
Closed

Prebuilt for node_v72 #78

BenoitClaveau opened this issue May 6, 2019 · 3 comments

Comments

@BenoitClaveau
Copy link

Could you please create a prebuilt for window node_v72.

@papandreou
Copy link

@chearon, sorry to ping you, but do you know why those win32 prebuilts aren't in the 2.6.0 release? Looks like you managed to include them in 2.5.0, except for the node 12/v72 one?

Would be great to have a canvas release with prebuilts supporting both win32 and node 12 😅

I don't have access to a Windows machine, but do let me know if there's anything else I can do to help :)

@chearon
Copy link
Member

chearon commented Aug 5, 2019

@papandreou no worries at all, I needed the extra push. Binaries for 2.6.0/Windows/all node versions are up, as well as 2.5.0/Windows/Node 12!

2.5.0: was an issue with the wrong NAN version.

2.6.0: AppVeyor must have updated their images because it immediately built and pushed the new binaries when I started testing various fixes to MSYS2.

Sorry for the long wait everyone. At least I have some good ideas in case MSYS2 breaks like this again.

@LinusU
Copy link

LinusU commented Aug 13, 2019

@chearon awesome 👏 👏 tagging latest to 2.6.0 now 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants