chore: upgrade canvas to version 2.5.0 to support node version 12 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
👍🏻 Tnx for the update! |
|
👍 Thanks. Unfortunately not all the prebuilts are available yet for 2.5.0 node-gfx/node-canvas-prebuilt#78. I will review again in a few weeks. |
|
@jamescryer Not sure why windows prebuilts are unavailable, but at least with 2.5.0 you'll get node v12 support on most systems where currently build will always fail on v12. |
|
Would love to see this as soon as possible ;-) |
|
@jamescryer, the missing prebuilts are up now: node-gfx/node-canvas-prebuilt#78 (comment) 😌 |
papandreou
added a commit
to unexpectedjs/unexpected-resemble
that referenced
this pull request
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why canvas js version was hardcoded to v2.2.0 but I upgraded to 2.5.0 (the only version to support node v12) and all tests seem to be passing